[jira] [Commented] (ARTEMIS-1602) Sending message from AMQP to STOMP fails because of NPE in StompSession

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16323010#comment-16323010 ] 

ASF GitHub Bot commented on ARTEMIS-1602:
-----------------------------------------

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/1774

    ARTEMIS-1602 avoid potential NPE if property is null

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-1602

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/1774.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1774
    
----
commit addd66837dea52fe8b7cff6d06145a92ca930b06
Author: Justin Bertram <jb...@...>
Date:   2018-01-11T21:06:01Z

    ARTEMIS-1602 avoid potential NPE if property is null

----


> Sending message from AMQP to STOMP fails because of NPE in StompSession
> -----------------------------------------------------------------------
>
>                 Key: ARTEMIS-1602
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1602
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: STOMP
>    Affects Versions: 2.4.0
>         Environment: Artemis 2.5.0-SNAPSHOT
>            Reporter: Johan Stenberg
>            Assignee: Justin Bertram
>         Attachments: Artemis1602Test.java, pom.xml
>
>
> Messages send from an AMQP client to a STOMP client never arrive because of an internal NPE at [StompSession.sendMessage()#L160|https://github.com/apache/activemq-artemis/blob/b8f591b6b9b84cbea599db95c6b743a2c4088319/artemis-protocols/artemis-stomp-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/stomp/StompSession.java#L160]
> {{serverMessage.getBooleanProperty(Message.HDR_LARGE_COMPRESSED)}} apparently returns null in that case and because of Boolean -> boolean auto-unboxing an NPE is thrown.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)