[GitHub] [incubator-daffodil] mbeckerle commented on a change in pull request #193: Ensure content/valueLength expressions are not considered constants

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #193: Ensure content/valueLength expressions are not considered constants
URL: https://github.com/apache/incubator-daffodil/pull/193#discussion_r263424877
 
 

 ##########
 File path: daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml
 ##########
 @@ -466,6 +480,20 @@
         </xs:sequence>
       </xs:complexType>
     </xs:element>
+
+    <xs:element name="contentLength3">
+      <xs:complexType>
+        <xs:sequence>
+          <xs:element name="x" dfdl:lengthKind="explicit" dfdl:length="{ 1 }">
+            <xs:complexType>
+              <xs:sequence>
+                <xs:element name="y" type="xs:int" dfdl:occursCountKind="expression" dfdl:occursCount='{ if (dfdl:contentLength(.., "bits") eq 0) then 1 else 2 }' maxOccurs="2" />
 
 Review comment:
   Hard to code review because lines are too long in this file. When changes to a file are more than a screenful, you have to scroll down to find the horizontal scroll bar, which makes this very challenging. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services