[PR] chore(repo): require a review and a green build before merging to main [iggy-website]

["hubcio (via GitHub)" <gi...@apache.org>]

hubcio opened a new pull request, #71:
URL: https://github.com/apache/iggy-website/pull/71

   Nothing in the branch ruleset required a pull request review or a
   passing build, so anyone with write access could merge their own PR
   into main with zero approvals, and a broken build was only caught by
   the deploy job after the fact.
   
   Add required_pull_request_reviews to the existing Default Branch
   Protection ruleset. One approval rather than the two apache/iggy
   uses on master: the site sees far less traffic and a two-committer
   gate would stall small doc fixes. Stale reviews are dismissed, the
   last push must be approved, and review threads must be resolved, so
   nothing slips through by merging past it.
   
   Add a CI workflow that runs npm ci and npm run build on every pull
   request and make it a required, strict status check: a PR must be
   up to date with main before it can merge, so the build that passed
   is the build that lands.
   
   npm ci rather than the npm install the deploy jobs use: it fails
   when package-lock.json drifts from package.json instead of quietly
   resolving something else. Node version comes from .nvmrc so there is
   one place to bump it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] chore(repo): require a review and a green build before merging to main [iggy-website]

["spetz (via GitHub)" <gi...@apache.org>]

spetz merged PR #71:
URL: https://github.com/apache/iggy-website/pull/71


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@iggy.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org