You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Eric Norman <en...@apache.org> on 2021/06/07 19:19:58 UTC
[VOTE] Release Apache Sling Form Based Authentication 1.0.22
Hi,
We solved 5 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12348251
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2469/
You can use this UNIX script to download the release and verify the
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
Usage:
sh check_staged_release.sh 2469 /tmp/sling-staging
Please vote to approve this release:
[ ] +1 Approve the release
[ ] 0 Don't care
[ ] -1 Don't release, because ...
This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.22
Posted by Daniel Klco <dk...@apache.org>.
+1
On Mon, Jun 7, 2021 at 3:20 PM Eric Norman <en...@apache.org> wrote:
> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348251
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2469/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2469 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
[CANCELED] [VOTE] Release Apache Sling Form Based Authentication 1.0.22
Posted by Eric Norman <en...@apache.org>.
Hi,
This vote is cancelled in order to deal with SLING-10472
<https://issues.apache.org/jira/browse/SLING-10472>
On Mon, Jun 7, 2021 at 12:19 PM Eric Norman <en...@apache.org> wrote:
> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348251
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2469/
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2469 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.22
Posted by Konrad Windszus <ko...@gmx.de>.
+1
Konrad
> On 7. Jun 2021, at 21:19, Eric Norman <en...@apache.org> wrote:
>
> Hi,
>
> We solved 5 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12348251
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2469/
>
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2469 /tmp/sling-staging
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
Re: [VOTE] Release Apache Sling Form Based Authentication 1.0.22
Posted by Eric Norman <en...@apache.org>.
Hi Stefan,
That's a good catch. I took a look at why that test fails on windows and
it looks like it is because the TokenStore#saveTokens method calls
"tmpTokenFile.renameTo(tokenFile)". On windows the File.renameTo call
fails if the destination file already exists. From what I can tell this
has been failing all along but there were no tests for the TokenStore until
a couple months ago.
I've opened SLING-10472 <https://issues.apache.org/jira/browse/SLING-10472> for
tracking the problem.
I'm going to cancel the release and include the fix for that problem and
then call for a new vote.
Regards,
Eric
On Tue, Jun 8, 2021 at 7:58 AM Stefan Seifert
<St...@diva-e.com.invalid> wrote:
> +1
>
>
> please note that the unit test do not run on my (windows) machine (they
> are running fine on linux, so it'S not a release blocker)
>
> [ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 3.948 s <<< FAILURE! - in org.apache.sling.auth.form.impl.TokenStoreTest
> [ERROR] org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest
> Time elapsed: 0.02 s <<< FAILURE!
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:87)
> at org.junit.Assert.assertTrue(Assert.java:42)
> at org.junit.Assert.assertTrue(Assert.java:53)
> at
> org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest(TokenStoreTest.java:92)
> ...
>
RE: [VOTE] Release Apache Sling Form Based Authentication 1.0.22
Posted by Stefan Seifert <St...@diva-e.com.INVALID>.
+1
please note that the unit test do not run on my (windows) machine (they are running fine on linux, so it'S not a release blocker)
[ERROR] Tests run: 6, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.948 s <<< FAILURE! - in org.apache.sling.auth.form.impl.TokenStoreTest
[ERROR] org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest Time elapsed: 0.02 s <<< FAILURE!
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:87)
at org.junit.Assert.assertTrue(Assert.java:42)
at org.junit.Assert.assertTrue(Assert.java:53)
at org.apache.sling.auth.form.impl.TokenStoreTest.loadTokenFileTest(TokenStoreTest.java:92)
...