You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2021/10/17 20:37:05 UTC

[GitHub] [fineract] IOhacker opened a new pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

IOhacker opened a new pull request #1893:
URL: https://github.com/apache/fineract/pull/1893


   ## Description
   
   It adds support for SonarQube Analysis related to this ticket https://issues.apache.org/jira/browse/FINERACT-1409
   
   After that the SonarQube Analysis results will be available at https://sonarcloud.io/project/configuration?id=apache_fineract  
   
   Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
   
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [X] Write the commit message as per https://github.com/apache/fineract/#pull-requests
   
   - [X] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
   
   - [X] Create/update unit or integration tests for verifying the changes made.
   
   - [X] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
   
   - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
   
   - [X] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the developer mailing list for guidance, if required.)
   
   FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] BLasan commented on pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1893:
URL: https://github.com/apache/fineract/pull/1893#issuecomment-946957055


   @IOhacker Please squash commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] BLasan commented on pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
BLasan commented on pull request #1893:
URL: https://github.com/apache/fineract/pull/1893#issuecomment-946961203


   PR looks ok to me !!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker closed pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
IOhacker closed pull request #1893:
URL: https://github.com/apache/fineract/pull/1893


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] BLasan edited a comment on pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
BLasan edited a comment on pull request #1893:
URL: https://github.com/apache/fineract/pull/1893#issuecomment-946957055


   @IOhacker Please squash the commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker merged pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
IOhacker merged pull request #1893:
URL: https://github.com/apache/fineract/pull/1893


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker commented on pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1893:
URL: https://github.com/apache/fineract/pull/1893#issuecomment-945204344


   Closinf for running again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] IOhacker commented on pull request #1893: Support for SonarQube Analysis on ASF's SonarCloud

Posted by GitBox <gi...@apache.org>.
IOhacker commented on pull request #1893:
URL: https://github.com/apache/fineract/pull/1893#issuecomment-945204374


   Opening for running again


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org