You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "mjsax (via GitHub)" <gi...@apache.org> on 2024/08/06 20:03:22 UTC

[PR] MINOR: Keep Kafka Streams configs ordered in code and docs [kafka]

mjsax opened a new pull request, #16816:
URL: https://github.com/apache/kafka/pull/16816

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Keep Kafka Streams configs ordered in code and docs [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #16816:
URL: https://github.com/apache/kafka/pull/16816


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Keep Kafka Streams configs ordered in code and docs [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #16816:
URL: https://github.com/apache/kafka/pull/16816#discussion_r1729602744


##########
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##########
@@ -1075,6 +1079,11 @@ public String toString() {
                     DefaultKafkaClientSupplier.class.getName(),
                     Importance.LOW,
                     DEFAULT_CLIENT_SUPPLIER_DOC)
+            .define(LOG_SUMMARY_INTERVAL_MS_CONFIG,
+                    Type.LONG,
+                   2 * 60 * 1000L,

Review Comment:
   ```suggestion
                       2 * 60 * 1000L,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Keep Kafka Streams configs ordered in code and docs [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on code in PR #16816:
URL: https://github.com/apache/kafka/pull/16816#discussion_r1729601744


##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -92,7 +93,6 @@
               <li><a class="reference internal" href="#task-assignor-class" id="id39">task.assignor.class</a></li>
               <li><a class="reference internal" href="#topology-optimization" id="id31">topology.optimization</a></li>
               <li><a class="reference internal" href="#windowed-inner-class-serde" id="id38">windowed.inner.class.serde</a></li>
-              <li><a class="reference internal" href="#log-summary-interval-ms" id="id40">log.summary.interval.ms</a></li>

Review Comment:
   This is a new config and it should be added at the right place. (The original PR was just a little "sloppy"...)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org