You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/09 08:49:18 UTC
[GitHub] [incubator-nuttx] no1wudi opened a new pull request #5703: arch/arm: Support setjmp/longjmp for all socs
no1wudi opened a new pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703
## Summary
After check the official specification of ARM ISA
and Thumb ISA, the arch_setjmp_thumb.S are written
by arm unified assembly language, so it easy to make it works for ARM and thumb ISA.
## Impact
setjmp/longjmp for Cortex A processor
## Testing
Tested on sabre-6quad:ostest (both thumb mode and arm mode)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822425999
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -24,10 +24,6 @@
#include <nuttx/config.h>
-/****************************************************************************
Review comment:
need update the file name at line 1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822603578
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,10 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
+ .thumb
Review comment:
It can be removed, it just a explicit description (a alias to `.code 16`) for thumb mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822631750
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,9 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
.thumb_func
Review comment:
can we remove thumb too? I suppose that gcc should generate the right instruction set with the corresponding option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822633145
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,9 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
.thumb_func
Review comment:
OK, in fact compiler will add this for each function automatically if `-mthumb` specified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822622398
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,10 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
+ .thumb
Review comment:
so, let's remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822604853
##########
File path: arch/Kconfig
##########
@@ -15,6 +15,7 @@ config ARCH_ARM
select ARCH_HAVE_STACKCHECK
select ARCH_HAVE_CUSTOMOPT
select ARCH_HAVE_STDARG_H
+ select ARCH_HAVE_SETJMP if !ARCH_TOOLCHAIN_IAR
Review comment:
Yes, GCC and Clang can handle arch_setjmp.S correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] no1wudi commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
no1wudi commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822625488
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,10 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
+ .thumb
Review comment:
OK, removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a change in pull request #5703: arch/arm: Support setjmp/longjmp for all socs
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822520975
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,10 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
+ .thumb
Review comment:
Do we really need `.thumb` here?
##########
File path: arch/Kconfig
##########
@@ -15,6 +15,7 @@ config ARCH_ARM
select ARCH_HAVE_STACKCHECK
select ARCH_HAVE_CUSTOMOPT
select ARCH_HAVE_STDARG_H
+ select ARCH_HAVE_SETJMP if !ARCH_TOOLCHAIN_IAR
Review comment:
So both GCC and Clang need it yes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org