You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by el...@apache.org on 2016/09/28 20:25:27 UTC

calcite git commit: [CALCITE-1399] Make the jcommander SerializationConverter public

Repository: calcite
Updated Branches:
  refs/heads/master 514d262e5 -> c9ec5c88d


[CALCITE-1399] Make the jcommander SerializationConverter public

When this class is private, JCommander fails because it
cannot instantiate the implementation and fails the program.


Project: http://git-wip-us.apache.org/repos/asf/calcite/repo
Commit: http://git-wip-us.apache.org/repos/asf/calcite/commit/c9ec5c88
Tree: http://git-wip-us.apache.org/repos/asf/calcite/tree/c9ec5c88
Diff: http://git-wip-us.apache.org/repos/asf/calcite/diff/c9ec5c88

Branch: refs/heads/master
Commit: c9ec5c88dd46e2c49ec3137d835b086708fbc4d6
Parents: 514d262
Author: Josh Elser <el...@apache.org>
Authored: Wed Sep 28 16:21:42 2016 -0400
Committer: Josh Elser <el...@apache.org>
Committed: Wed Sep 28 16:21:42 2016 -0400

----------------------------------------------------------------------
 .../java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/calcite/blob/c9ec5c88/avatica/standalone-server/src/main/java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java
----------------------------------------------------------------------
diff --git a/avatica/standalone-server/src/main/java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java b/avatica/standalone-server/src/main/java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java
index dbd632c..3e873a5 100644
--- a/avatica/standalone-server/src/main/java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java
+++ b/avatica/standalone-server/src/main/java/org/apache/calcite/avatica/hsqldb/HsqldbServer.java
@@ -113,9 +113,9 @@ public class HsqldbServer {
   }
 
   /**
-   * Converter from String to Serialization.
+   * Converter from String to Serialization. Must be public for JCommander.
    */
-  private static class SerializationConverter implements IStringConverter<Serialization> {
+  public static class SerializationConverter implements IStringConverter<Serialization> {
     @Override public Serialization convert(String value) {
       return Serialization.valueOf(value.toUpperCase());
     }