You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "heyihong (via GitHub)" <gi...@apache.org> on 2023/09/27 16:15:37 UTC
[GitHub] [spark] heyihong opened a new pull request, #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
heyihong opened a new pull request, #43153:
URL: https://github.com/apache/spark/pull/43153
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339979053
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
NVM, I misunderstood the python logics... Good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339972197
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -923,7 +928,7 @@ object SparkSession extends Logging {
*/
def create(): SparkSession = {
val session = tryCreateSessionFromClient()
- .getOrElse(SparkSession.this.create(builder.configuration))
+ .getOrElse(SparkSession.this.create(getClientConfiguration()))
setDefaultAndActiveSession(session)
applyOptions(session)
session
Review Comment:
Orthogonal: Why are create and getOrCreate functions exactly the same, while I think they should be doing something slightly different??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339981254
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -923,7 +928,7 @@ object SparkSession extends Logging {
*/
def create(): SparkSession = {
val session = tryCreateSessionFromClient()
- .getOrElse(SparkSession.this.create(builder.configuration))
+ .getOrElse(SparkSession.this.create(getClientConfiguration()))
setDefaultAndActiveSession(session)
applyOptions(session)
session
Review Comment:
`getOrCreate()` will try to retrieve cached SparkSession if exists. `create()` only creates a new SparkSession
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339979053
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
In python, SPARK_REMOTE value makes the final override before [RemoteSparkSession.builder.config(map=opts).getOrCreate()](https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L479) if I understand correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339963445
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
in this case, SPARK_REMOTE will take precedence over what was explicitly set in the builder, right?
so having in env
```
SPARK_REMOTE="sc://foo:123"
```
and calling
```
SparkSession.builder.remote("sc://bar:234").create()
```
then the SPARK_REMOTE will take precedence? Documentation does not specify precedence, but it feels like setting `remote` explicitly should take precedence over env var (and it should also be specified in the documentation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] hvanhovell closed pull request #43153: [SPARK-45360][SQL][CONNECT] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "hvanhovell (via GitHub)" <gi...@apache.org>.
hvanhovell closed pull request #43153: [SPARK-45360][SQL][CONNECT] Initialize spark session builder configuration from SPARK_REMOTE
URL: https://github.com/apache/spark/pull/43153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on PR #43153:
URL: https://github.com/apache/spark/pull/43153#issuecomment-1738909379
@hvanhovell @juliuszsompolski Please take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] vsevolodstep-db commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "vsevolodstep-db (via GitHub)" <gi...@apache.org>.
vsevolodstep-db commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339988135
##########
connector/connect/client/jvm/src/test/scala/org/apache/spark/sql/connect/client/SparkConnectClientSuite.scala:
##########
@@ -112,6 +130,35 @@ class SparkConnectClientSuite extends ConnectFunSuite with BeforeAndAfterEach {
}
}
+ test("SparkSession create with SPARK_REMOTE") {
Review Comment:
It's worth to also have a test covering combination of both `SPARK_REMOTE` env variable and `builder.remote(...)` call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1340001886
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -923,7 +928,7 @@ object SparkSession extends Logging {
*/
def create(): SparkSession = {
val session = tryCreateSessionFromClient()
- .getOrElse(SparkSession.this.create(builder.configuration))
+ .getOrElse(SparkSession.this.create(getClientConfiguration()))
setDefaultAndActiveSession(session)
applyOptions(session)
session
Review Comment:
:facepalm: I'm blind and didn't notice the `SparkSession.this.create` vs `sessions.get`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339979053
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
SPARK_REMOTE value makes the final override before [RemoteSparkSession.builder.config(map=opts).getOrCreate()](https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L479) if I understand correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339971246
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
In python, the explicity set remote config set in https://github.com/apache/spark/blob/master/python/pyspark/sql/connect/session.py#L143 takes precedence over env in https://github.com/apache/spark/blob/master/python/pyspark/sql/session.py#L470
It should be the same in scala, and the precedence should be documented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] heyihong commented on a diff in pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "heyihong (via GitHub)" <gi...@apache.org>.
heyihong commented on code in PR #43153:
URL: https://github.com/apache/spark/pull/43153#discussion_r1339979053
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/SparkSession.scala:
##########
@@ -912,6 +912,11 @@ object SparkSession extends Logging {
@deprecated(message = "Please use create() instead.", since = "3.5.0")
def build(): SparkSession = create()
+ private def getClientConfiguration(): Configuration = {
+ // Use copy() to avoid modifying the state of the existing builder.
+ builder.copy().loadFromEnvironment().configuration
Review Comment:
NVM, I misunderstood the python logics...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] juliuszsompolski commented on pull request #43153: [SPARK-45360] Initialize spark session builder configuration from SPARK_REMOTE
Posted by "juliuszsompolski (via GitHub)" <gi...@apache.org>.
juliuszsompolski commented on PR #43153:
URL: https://github.com/apache/spark/pull/43153#issuecomment-1738988309
Looks like `loadFromEnvironment()` could be called at Builder creation time, so that it's seeded with the settings from env, and then can be overiden by explicit calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org