You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/07/16 23:34:35 UTC
[kudu-CR] [build-support] add second deadlock stack=1 TSAN option
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10955
Change subject: [build-support] add second_deadlock_stack=1 TSAN option
......................................................................
[build-support] add second_deadlock_stack=1 TSAN option
Added 'second_deadlock_stack=1' to the list of TSAN options to output
detailed information on both parties when TSAN reports on potential
deadlocks.
Change-Id: Iee8dec04a9c31fa9c2d5a54d7d1e3a548c3b7512
---
M build-support/run-test.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/55/10955/1
--
To view, visit http://gerrit.cloudera.org:8080/10955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee8dec04a9c31fa9c2d5a54d7d1e3a548c3b7512
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [build-support] add second deadlock stack=1 TSAN option
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10955 )
Change subject: [build-support] add second_deadlock_stack=1 TSAN option
......................................................................
Patch Set 1:
> I think this has some performance impact -- any nervousness that
> this will make TSAN tests more flaky?
I didn't find it increased flakiness for the set of tests I ran, but that was very limited set of tests. Anyway, if we have doubts in making TSAN tests more flaky, I think it's better to use this flag only when it's necessary then.
--
To view, visit http://gerrit.cloudera.org:8080/10955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8dec04a9c31fa9c2d5a54d7d1e3a548c3b7512
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 00:39:45 +0000
Gerrit-HasComments: No
[kudu-CR] [build-support] add second deadlock stack=1 TSAN option
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has abandoned this change. ( http://gerrit.cloudera.org:8080/10955 )
Change subject: [build-support] add second_deadlock_stack=1 TSAN option
......................................................................
Abandoned
There is a concern about making TSAN tests more flaky with option, so it's safe to only enable it if it's really necessary.
--
To view, visit http://gerrit.cloudera.org:8080/10955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iee8dec04a9c31fa9c2d5a54d7d1e3a548c3b7512
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [build-support] add second deadlock stack=1 TSAN option
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10955 )
Change subject: [build-support] add second_deadlock_stack=1 TSAN option
......................................................................
Patch Set 1:
I think this has some performance impact -- any nervousness that this will make TSAN tests more flaky?
--
To view, visit http://gerrit.cloudera.org:8080/10955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee8dec04a9c31fa9c2d5a54d7d1e3a548c3b7512
Gerrit-Change-Number: 10955
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Tue, 17 Jul 2018 00:34:04 +0000
Gerrit-HasComments: No