[GitHub] [solr] cpoerschke edited a comment on pull request #497: SOLR-15852 Update dev-tools/scripts for 9.0

[GitBox <gi...@apache.org>]

cpoerschke edited a comment on pull request #497:
URL: https://github.com/apache/solr/pull/497#issuecomment-1012112346


   Hi @janhoy!
   
   I started looking here today with
   
   ```
   python3 -m pylint {buildAndPushRelease,releaseWizard,scriptutil,smokeTestRelease}.py
   ```
   
   and a local `.pylintrc` which ignores most of the warnings; pushed a commit with very selective changes, hopefully uncontroversial but feel free to revert if it's not the right time and place here.
   
   There were some warnings though which I didn't quite want to ignore-and-dismiss as such since they seemed interesting, so sharing them here, noting that some of the imports failed for me locally in case that could be a factor. What do you think?
   
   ```
   ************* Module releaseWizard
   releaseWizard.py:914:4: W0602: Using global for 'state' but no assignment is done (global-variable-not-assigned)
   releaseWizard.py:1355:4: W0601: Global variable 'state' undefined at the module level (global-variable-undefined)
   releaseWizard.py:1357:4: W0601: Global variable 'templates' undefined at the module level (global-variable-undefined)
   releaseWizard.py:1411:4: W0601: Global variable 'solr_news_file' undefined at the module level (global-variable-undefined)
   ************* Module smokeTestRelease
   smokeTestRelease.py:630:6: E0602: Undefined variable 'testDemo' (undefined-variable)
   ```
   
   edit: fixed the local import failures, then the warnings above remain and there's one additional interesting warning.
   
   ```
   releaseWizard.py:1347:4: W0221: Number of parameters was 3 in 'ExitItem.show' and is now 2 in overridden 'CustomExitItem.show' method (arguments-differ)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org