You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by lihanharry <gi...@git.apache.org> on 2018/03/21 18:20:21 UTC
[GitHub] thrift pull request #1515: add connect timeout, support accurate send timeou...
GitHub user lihanharry opened a pull request:
https://github.com/apache/thrift/pull/1515
add connect timeout, support accurate send timeout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lihanharry/thrift master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1515
----
commit 4e5a2aa039f9a3edb33e18411750b74a39b9c454
Author: harry <ha...@...>
Date: 2015-12-15T10:10:50Z
update TSocket.php
add conntimeout
support accurate send timeout and write timeout
commit 93affda4d6aefcb88929cd53e2f29cd6287b4d3e
Author: harry <ha...@...>
Date: 2015-12-15T10:28:23Z
modify code style
commit 588200508ac14951cc472ea6de34651ae7a202aa
Author: harry <ha...@...>
Date: 2015-12-15T11:04:11Z
modify code style
commit 644d7314204baad808220ffffc98ec054032ac48
Author: harry <ha...@...>
Date: 2015-12-15T11:06:37Z
modify code style
commit a8a2dbf326c0f35e79378722f2629e6805e57f84
Author: netbit <li...@...>
Date: 2018-03-21T17:55:57Z
rm Thrift/Transport/TSocket.php
commit 565e2982635c03bb33139330e815598927bbc983
Author: netbit <li...@...>
Date: 2018-03-21T17:58:34Z
add conntimeout
support accurate send timeout and write timeout
Please enter the commit message for your changes. Lines starting
commit 82faf6e23caf5477e7cdd8b419f9437598189121
Author: netbit <li...@...>
Date: 2018-03-21T18:10:46Z
modify codestyle
----
---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Posted by dcelasun <gi...@git.apache.org>.
Github user dcelasun commented on the issue:
https://github.com/apache/thrift/pull/1515
Please don't change the code style while you are doing unrelated changes, it makes it very hard to review what *actually* changed. Even with the changes, there are lots of style inconsistencies like opening braces for functions are sometimes on the same line, sometimes on a new line.
So please revert any style-only changes and follow the existing style. If you want to also change/improve code style, open a separate PR for that. Thank you.
---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
THRIFT-4171
---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
Fortunately these changes are confined to one file so reviewing it isn't too bad - hopefully they pass the new php formatting tests in the sca build.
---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
The new style changes and checks are pretty recent, based on work done by @RobberPhex.
---
[GitHub] thrift issue #1515: add connect timeout, support accurate send timeout
Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:
https://github.com/apache/thrift/pull/1515
Please squash your changes to a single commit if possible. Thanks.
---