[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24590: [SPARK-27687][SS] Rename Kafka consumer cache capacity and document caching

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24590: [SPARK-27687][SS] Rename Kafka consumer cache capacity and document caching
URL: https://github.com/apache/spark/pull/24590#discussion_r283429363
 
 

 ##########
 File path: external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/package.scala
 ##########
 @@ -33,8 +33,8 @@ package object kafka010 {   // scalastyle:ignore
       .createWithDefaultString("10m")
 
   private[kafka010] val CONSUMER_CACHE_CAPACITY =
 
 Review comment:
   Thank you for new doc, @gaborgsomogyi .
   Since this is used since Spark 2.0.x, shall we add a comment on the migration doc?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org