You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/10/10 09:40:34 UTC

[PR] perf(runtime): advance fuzzy Edit line offsets incrementally [maka]

seekskyworld opened a new pull request, #6050:
URL: https://github.com/apache/maka/pull/6050

   ## Summary
   
   Edit's line-trimmed fallback rescans every preceding line to locate each matching candidate. Track the source offset once as lines advance, preserving candidate selection, ambiguity errors, newline handling and line ranges. On an admitted 49,000-line repetitive fixture, median helper latency falls from **653.52ms to 4.48ms** (10 samples per version; method and reproduction in the issue).
   
   Fixes #6049
   
   ## Verification
   
   - 64 Edit / filesystem-worker / tool-entry tests pass; the 22 Edit tests also pass on Node 22.19.0.
   - The new CPU-budget regression fails on the old implementation (2.69 CPU seconds for four edits) and passes with this change. 18,000 seeded before/after cases produce identical results or errors.
   - Repository build, typecheck, lint, format, Desktop/UI knip, ASF headers and diff checks pass.
   - Full Runtime was **not entirely green**: each of two runs had 3,830 pass / 14 skip / 1 failure, in different unchanged process-lifecycle fixtures (`owned-child-process` descendant cleanup, then `shell-owner-death` reading incomplete fixture JSON). The first failing case passes in isolation and its unchanged baseline suite passes 12/12. These failures are retained in the validation record; no unrelated test was weakened.
   
   ## AI use
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex investigated, implemented and tested this change at @seekskyworld's direction. Final review and merge remain human decisions.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] perf(runtime): advance fuzzy Edit line offsets incrementally [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #6050:
URL: https://github.com/apache/maka/pull/6050


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org