You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/07 10:41:26 UTC

[GitHub] [arrow] nevi-me commented on pull request #8590: ARROW-10042: [Rust] BufferData's equality should depend on its capacity; ArrayData's equality should not depend on its BufferDatas' capacities' equality

nevi-me commented on pull request #8590:
URL: https://github.com/apache/arrow/pull/8590#issuecomment-723429467


   > One idea:
   > 
   > 1. Make the array comparison on the parquet tests be done using the `PartialEq`, like this PR is doing
   > 2. Make `PartialEq` use the function `equal` being introduced on #8541
   > 3. Remove both `#[ignore]`
   
   I also like this approach, as #8541 now accounts for logical equality


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org