You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/04 08:46:44 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4442: Forward
compatibility for DCS
wu-sheng opened a new pull request #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442
In the old implementation of DCS, the old one will not response UUID, which could make the update not work.
This make the forward compatibility for DCS, enhance #4438
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr merged pull request #4442: Forward
compatibility for DCS
Posted by GitBox <gi...@apache.org>.
dmsolr merged pull request #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4442: Forward
compatibility for DCS
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442#issuecomment-594413820
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=h1) Report
> Merging [#4442](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/d32450aa7d29a2ccb1b0d48ee251d2d1ef8851af?src=pr&el=desc) will **increase** coverage by `0.02%`.
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4442 +/- ##
==========================================
+ Coverage 25.1% 25.13% +0.02%
==========================================
Files 1211 1211
Lines 28096 28096
Branches 3868 3868
==========================================
+ Hits 7054 7061 +7
+ Misses 20393 20386 -7
Partials 649 649
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [.../configuration/grpc/GRPCConfigWatcherRegister.java](https://codecov.io/gh/apache/skywalking/pull/4442/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9ncnBjLWNvbmZpZ3VyYXRpb24tc3luYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vZ3JwYy9HUlBDQ29uZmlnV2F0Y2hlclJlZ2lzdGVyLmphdmE=) | `0% <0%> (ø)` | :arrow_up: |
| [...walking/oap/server/core/analysis/Downsampling.java](https://codecov.io/gh/apache/skywalking/pull/4442/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93bnNhbXBsaW5nLmphdmE=) | `100% <0%> (+100%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=footer). Last update [d32450a...93f89d4](https://codecov.io/gh/apache/skywalking/pull/4442?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4442: Forward compatibility
for DCS
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442#issuecomment-594411578
Emma, what does DCS mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on issue #4442: Forward
compatibility for DCS
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442#issuecomment-594415010
@dmsolr read #4438? DCS = Dynamic Configuration Service. A gRPC based integration way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] dmsolr commented on issue #4442: Forward compatibility
for DCS
Posted by GitBox <gi...@apache.org>.
dmsolr commented on issue #4442: Forward compatibility for DCS
URL: https://github.com/apache/skywalking/pull/4442#issuecomment-594417143
> @dmsolr read #4438? DCS = Dynamic Configuration Service. A gRPC based integration way.
Got it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services