[jira] [Commented] (FLINK-33136) Flink Pulsar Connector RoundRobinTopicRouter Generates Invalid Error Message

["Yufan Sheng (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-33136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837161#comment-17837161 ] 

Yufan Sheng commented on FLINK-33136:
-------------------------------------

Yep, I think you are right. We should use more perspective words to describe the issue that no topics is present. BTW, add the check in the {{PulsarSink}}. PR is welcome.

> Flink Pulsar Connector RoundRobinTopicRouter Generates Invalid Error Message
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-33136
>                 URL: https://issues.apache.org/jira/browse/FLINK-33136
>             Project: Flink
>          Issue Type: Bug
>          Components: Connectors / Pulsar
>    Affects Versions: 1.17.1
>            Reporter: Jason Kania
>            Priority: Major
>
> The RoundRobinTopicRouter class generates the runtime error "You should provide topics for routing topic by message key hash." when no partitions are set. This error is a direct copy of the error in the KeyHashTopicRouter but is nonsensical to a RoundRobinTopicRouter since hashing is not involved in route selection.
> More importantly however, this error should be detected at deploy time when the PulsarSink is built with the builder since the list of topics is supplied via the setTopics() method of the builder.
> Additionally, the wording of the error is not clear in any case and could be improved to something like: "No partition routing topics were provided to allow for topic routing"
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)