[GitHub] [incubator-kyuubi] turboFei commented on a change in pull request #1442: Fix encode MySQLHandshakePacket UT

[GitBox <gi...@apache.org>]

turboFei commented on a change in pull request #1442:
URL: https://github.com/apache/incubator-kyuubi/pull/1442#discussion_r755666498



##########
File path: kyuubi-server/src/test/scala/org/apache/kyuubi/server/mysql/authentication/MySQLAuthPacketSuite.scala
##########
@@ -31,15 +31,17 @@ class MySQLAuthPacketSuite extends KyuubiFunSuite with MySQLCodecHelper {
   }
 
   test("encode MySQLHandshakePacket") {
-    val packet = MySQLHandshakePacket(2, authPluginData)
+    val packet = new MySQLHandshakePacket(2, authPluginData) {
+      override def serverVersion: String = "5.7.22-Kyuubi-Server v1.4.0-incubating"

Review comment:
       should we use `dummy` here?
   
   ```
         override def serverVersion: String = "dummy"
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org