You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2012/12/11 23:36:19 UTC

Re: Review Request: Added helpers to extract resources

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8145/#review14319
-----------------------------------------------------------



src/tests/resources_tests.cpp
<https://reviews.apache.org/r/8145/#comment30493>

    Do you need this?


- Benjamin Hindman


On Nov. 21, 2012, 6:32 p.m., Vinod Kone wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8145/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2012, 6:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Ben Mahler.
> 
> 
> Description
> -------
> 
> Added helpers to extract specific resources: cpus,mem, disk and ports.
> 
> I wanted these as part of a fix I am going to make to the slave, to properly deal with resources specified via command line.
> 
> Hopefully, once we make the resources first class, we don't need these helpers?
> 
> 
> Diffs
> -----
> 
>   src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd 
>   src/tests/resources_tests.cpp 83e93482a6800724d51aeae91e57d2a2b52b37b6 
> 
> Diff: https://reviews.apache.org/r/8145/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Vinod Kone
> 
>