You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "Reamer (via GitHub)" <gi...@apache.org> on 2024/10/25 08:14:37 UTC
[PR] [ZEPPELIN-6138] Update Apache Parent [zeppelin]
Reamer opened a new pull request, #4884:
URL: https://github.com/apache/zeppelin/pull/4884
### What is this PR for?
This pull request updates the Apache parent version. We benefit significantly from plugin updates and can clean up our own `pom.xml`.
plugin updates:
maven-antrun-plugin - 1.8 -> 3.1.0
maven-assembly-plugin - 3.7.1 -> 3.7.1
maven-clean-plugin - 3.1.0 -> 3.4.0
maven-compiler-plugin - 3.8.1 -> 3.13.0
maven-dependency-plugin - 3.1.2 -> 3.7.1
maven-deploy-plugin - 2.8.2 -> 3.1.2
maven-enforcer-plugin - 3.0.0-M3 -> 3.5.0
maven-gpg-plugin - 1.6 -> 3.2.4
apache-rat-plugin - 0.13 -> 0.16.1
surefire & failsafe version - 3.2.2 -> 3.3.0
### What type of PR is it?
Improvement
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-6138
### How should this be tested?
* CI
### Questions:
* Does the license files need to update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Update Apache Parent [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer merged PR #4884:
URL: https://github.com/apache/zeppelin/pull/4884
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Update Apache Parent [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on code in PR #4884:
URL: https://github.com/apache/zeppelin/pull/4884#discussion_r1818480465
##########
elasticsearch/src/test/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreterTest.java:
##########
@@ -94,33 +94,31 @@ public static void populate() throws IOException {
.setRefresh(true)
.setSource(jsonBuilder()
.startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
- .get();
+ .field("date", new Date())
+ .startObject("request")
+ .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
+ .field("url", "/zeppelin/" + UUID.randomUUID().toString())
+ .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
+ .endObject()
+ .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
+ .field("content_length", RandomUtils.nextInt(0, 2000))
+ ).get();
}
for (int i = 1; i < 3; i++) {
elsClient.prepareIndex("logs", "http", "very/strange/id#" + i)
.setRefresh(true)
.setSource(jsonBuilder()
- .startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
Review Comment:
Thank you for your review. I have adjusted the indentation. How does it look now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Update Apache Parent [zeppelin]
Posted by "Reamer (via GitHub)" <gi...@apache.org>.
Reamer commented on PR #4884:
URL: https://github.com/apache/zeppelin/pull/4884#issuecomment-2440922341
Merged into master/branch-0.12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ZEPPELIN-6138] Update Apache Parent [zeppelin]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #4884:
URL: https://github.com/apache/zeppelin/pull/4884#discussion_r1818325013
##########
elasticsearch/src/test/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreterTest.java:
##########
@@ -94,33 +94,31 @@ public static void populate() throws IOException {
.setRefresh(true)
.setSource(jsonBuilder()
.startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
- .get();
+ .field("date", new Date())
+ .startObject("request")
+ .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
+ .field("url", "/zeppelin/" + UUID.randomUUID().toString())
+ .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
+ .endObject()
+ .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
+ .field("content_length", RandomUtils.nextInt(0, 2000))
+ ).get();
}
for (int i = 1; i < 3; i++) {
elsClient.prepareIndex("logs", "http", "very/strange/id#" + i)
.setRefresh(true)
.setSource(jsonBuilder()
- .startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
Review Comment:
can we keep the indent? the original one has better readability
##########
elasticsearch/src/test/java/org/apache/zeppelin/elasticsearch/ElasticsearchInterpreterTest.java:
##########
@@ -94,33 +94,31 @@ public static void populate() throws IOException {
.setRefresh(true)
.setSource(jsonBuilder()
.startObject()
- .field("date", new Date())
- .startObject("request")
- .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
- .field("url", "/zeppelin/" + UUID.randomUUID().toString())
- .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
- .endObject()
- .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
- .field("content_length", RandomUtils.nextInt(0, 2000))
- )
- .get();
+ .field("date", new Date())
+ .startObject("request")
+ .field("method", METHODS[RandomUtils.nextInt(0, METHODS.length)])
+ .field("url", "/zeppelin/" + UUID.randomUUID().toString())
+ .field("headers", Arrays.asList("Accept: *.*", "Host: apache.org"))
+ .endObject()
+ .field("status", STATUS[RandomUtils.nextInt(0, STATUS.length)])
+ .field("content_length", RandomUtils.nextInt(0, 2000))
+ ).get();
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org