You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Luke Prentice (JIRA)" <ji...@apache.org> on 2008/07/25 09:25:31 UTC
[jira] Created: (OFBIZ-1895) handle empty city in
handle empty city in
---------------------
Key: OFBIZ-1895
URL: https://issues.apache.org/jira/browse/OFBIZ-1895
Project: OFBiz
Issue Type: Improvement
Components: order
Affects Versions: SVN trunk
Environment: ubuntu 8.10, java 1.6, postgres 8.2
Reporter: Luke Prentice
Priority: Minor
this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
${postalAddress.city}
so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
context:
<#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
<#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
${postalAddress.address1}<br/>
<#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
${postalAddress.postalCode?if_exists}<br/>
${postalAddress.countryGeoId?if_exists}<br/>
<#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Luke Prentice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luke Prentice updated OFBIZ-1895:
---------------------------------
Issue Type: Bug (was: Improvement)
changed from enhancement to bug.
SVN version of file: 679658
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Priority: Minor
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Luke Prentice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616805#action_12616805 ]
Luke Prentice commented on OFBIZ-1895:
--------------------------------------
our problem arose because we are in the process of upgrading our ofbiz base framework but using historical data created under an older (approx 2 years) ofbiz base where city either did not exist or was optional.
we cannot repopulate our existing addresses with city.
i understand that this is a mandatory field field on the forms. is it a mandatory field in the entity model too?
either way, isn't it safer to use ?if_exists ?
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Priority: Minor
> Attachments: ordercontactinfo.ftl.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Luke Prentice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luke Prentice updated OFBIZ-1895:
---------------------------------
Attachment: ordercontactinfo.ftl.diff
patch file to checkin please.
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Priority: Minor
> Attachments: ordercontactinfo.ftl.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jacques Le Roux closed OFBIZ-1895.
----------------------------------
Resolution: Fixed
Fix Version/s: Release Branch 4.0
SVN trunk
Assignee: Jacques Le Roux
Thanks Luke,
Your patch is in trunk rev. 679704 and release4.0 679710
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: ordercontactinfo.ftl.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616812#action_12616812 ]
Jacques Le Roux commented on OFBIZ-1895:
----------------------------------------
It can't hurt anyway, so I put it in release4.0 too
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Assignee: Jacques Le Roux
> Priority: Minor
> Fix For: SVN trunk, Release Branch 4.0
>
> Attachments: ordercontactinfo.ftl.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Vikas Mayur (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616796#action_12616796 ]
Vikas Mayur commented on OFBIZ-1895:
------------------------------------
Hi Luke,
City is the required field on all the forms that involves editing a address. In any case PostalAddress will have this field, so there is no need to
add a check ?if_exists.
Can you please write down the step to reproduce this error. Else I would like to close this issue as I did not see this error.
- Vikas
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Bug
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Priority: Minor
> Attachments: ordercontactinfo.ftl.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-1895) handle empty city in
ordercontactinfo.ftl
Posted by "Luke Prentice (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Luke Prentice updated OFBIZ-1895:
---------------------------------
Summary: handle empty city in ordercontactinfo.ftl (was: handle empty city in )
> handle empty city in ordercontactinfo.ftl
> -----------------------------------------
>
> Key: OFBIZ-1895
> URL: https://issues.apache.org/jira/browse/OFBIZ-1895
> Project: OFBiz
> Issue Type: Improvement
> Components: order
> Affects Versions: SVN trunk
> Environment: ubuntu 8.10, java 1.6, postgres 8.2
> Reporter: Luke Prentice
> Priority: Minor
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
> this expression in applications/order/webapp/ordermgr/order/ordercontactinfo.ftl (line 83) fails if city is empty:
> ${postalAddress.city}
> so changed it to ${postalAddress.city?if_exists} and it's ok. simply add ?if_exists
> context:
> <#if postalAddress.toName?has_content><span class="label">${uiLabelMap.CommonTo}</span> ${postalAddress.toName}<br/></#if>
> <#if postalAddress.attnName?has_content><span class="label">${uiLabelMap.CommonAttn}</span> ${postalAddress.attnName}<br/></#if>
> ${postalAddress.address1}<br/>
> <#if postalAddress.address2?has_content>${postalAddress.address2}<br/></#if>
> ${postalAddress.city?if_exists}<#if postalAddress.stateProvinceGeoId?has_content>, ${postalAddress.stateProvinceGeoId} </#if>
> ${postalAddress.postalCode?if_exists}<br/>
> ${postalAddress.countryGeoId?if_exists}<br/>
> <#if !postalAddress.countryGeoId?exists || postalAddress.countryGeoId == "USA">
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.