[GitHub] [flink] cshuo commented on a change in pull request #16669: [FLINK-23544][table-planner]Window TVF Supports session window

[GitBox <gi...@apache.org>]

cshuo commented on a change in pull request #16669:
URL: https://github.com/apache/flink/pull/16669#discussion_r684576306



##########
File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowAggregate.scala
##########
@@ -104,14 +105,50 @@ class StreamPhysicalWindowAggregate(
 
   override def translateToExecNode(): ExecNode[_] = {
     checkEmitConfiguration(FlinkRelOptUtil.getTableConfigFromContext(this))
-    new StreamExecWindowAggregate(
-      grouping,
-      aggCalls.toArray,
-      windowing,
-      namedWindowProperties.toArray,
-      InputProperty.DEFAULT,
-      FlinkTypeFactory.toLogicalRowType(getRowType),
-      getRelDetailedDescription
-    )
+    windowing.getWindow match {
+      case windowSpec: SessionWindowSpec =>
+        windowing match {
+          case timeWindowStrategy: TimeAttributeWindowingStrategy =>
+            val (timeAttributeFieldName, timeAttributeIdx) = if (timeWindowStrategy.isRowtime) {

Review comment:
       branch here is not necessary, proctime case will be processed properly inside window op




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org