[jira] [Commented] (ARROW-2442) [C++] Disambiguate Builder::Append overloads

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439823#comment-16439823 ] 

ASF GitHub Bot commented on ARROW-2442:
---------------------------------------

pitrou opened a new pull request #1900: ARROW-2442: [C++] Disambiguate builder Append() overloads
URL: https://github.com/apache/arrow/pull/1900
 
 
   Vector-style Append() methods are renamed AppendValues().
   The original methods are marked deprecated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [C++] Disambiguate Builder::Append overloads
> --------------------------------------------
>
>                 Key: ARROW-2442
>                 URL: https://issues.apache.org/jira/browse/ARROW-2442
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Antoine Pitrou
>            Priority: Major
>              Labels: beginner, pull-request-available
>
> See discussion in [https://github.com/apache/arrow/pull/1852#discussion_r179919627]
> There are various {{Append()}} overloads in Builder and subclasses, some of which append one value, some of which append multiple values at once.
> The API might be clearer and less error-prone if multiple-append variants were named differently, for example {{AppendValues()}}. Especially with the pointer-taking variants, it's probably easy to call the wrong overload by mistake.
> The existing methods would have to go through a deprecation cycle.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)