You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/06/05 12:26:40 UTC

[GitHub] [spark] bart-samwel commented on pull request #28703: SPARK-29897 Add implicit cast for SubtractTimestamps

bart-samwel commented on pull request #28703:
URL: https://github.com/apache/spark/pull/28703#issuecomment-639451001


   Isn't this ambiguous? You have:
   
   <timestamp> - <interval> returns <timestamp>
   <timestamp> - <timestamp> returns <interval>
   
   So the second argument could be a timestamp or an interval. (I haven't checked that we support both of these, but even if we don't support one of these now, we might add that support in the future.)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org