You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/17 22:47:37 UTC

[GitHub] [airflow] dstandish commented on a change in pull request #17934: Add dags.gitSync.sshKeyCustomFile parameter to allow other SSH key sources

dstandish commented on a change in pull request #17934:
URL: https://github.com/apache/airflow/pull/17934#discussion_r771731034



##########
File path: chart/values.yaml
##########
@@ -1308,6 +1308,7 @@ dags:
     extraVolumeMounts: []
     env: []
     resources: {}
+    sshKeyCustomFile:

Review comment:
       i agree with @jedcunningham 
   
   and maybe what  we can do here is, `sshKeyFile` can have an explicit default of `/etc/git-secret/ssh`
   
   then we could reference this config instead of hardcoding e.g. in `_helpers.py` when setting `GIT_SSH_KEY_FILE`
   
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org