[GitHub] MaxGekk commented on issue #23341: [SPARK-26081][SQL][FOLLOW-UP] Use foreach instead of misuse of map (for Unit)

[GitBox <gi...@apache.org>]

MaxGekk commented on issue #23341: [SPARK-26081][SQL][FOLLOW-UP] Use foreach instead of misuse of map (for Unit)
URL: https://github.com/apache/spark/pull/23341#issuecomment-448141616
 
 
   Just wondering to not misuse it in the future.
   
   > This could cause some weird errors potentially...
   
   What kind of problems could it cause in the case of `Option`? Additional wrapping by `Some`? ... but `close()` is called not so often. 
   
    > it's not a good practice anyway ...
   
   Is it good practice to depend on called function? If `close()` of `UnivocityGenerator` will be changed in the future and will return `Boolean` instead of `Unit`, will you change `foreach` back to `map`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org