You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/06/01 21:27:22 UTC
[GitHub] [trafficserver] zwoop opened a new pull request, #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
zwoop opened a new pull request, #8879:
URL: https://github.com/apache/trafficserver/pull/8879
This allows for a plugin to introspect itself when TSRemapInit() is
being called. It's currently only implementing TSRemapDLHandleGet(),
which returns the handle to the .so as returned by dlopen(). With
this handle, a plugin can use e.g. dlsym() and dlinfo() to introspect
the plugin that it's loaded with.
Note that I've put this on 10-Dev. It's perhaps not ABI incompatible,
but seeing that it changes ts/remap.h internals, better to be safe
then sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] shukitchan commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
shukitchan commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1144330136
can we add an example and documentation? That will be really helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
bneradt commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1149336611
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1150430662
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
randall commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1146145482
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1148850762
Added a doc section, but not an example (the API is pretty clear IMO, and none of the existing plugins needs it).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop merged pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
zwoop merged PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1144687175
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1144160621
This also fixes an unrelated clang-format issue that snuck into the 10-Dev branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] randall commented on a diff in pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
randall commented on code in PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#discussion_r891415958
##########
doc/developer-guide/api/functions/TSTypes.en.rst:
##########
@@ -196,6 +196,16 @@ more widely. Those are described on this page.
The API version of the C API. The lower 16 bits are the minor version, and the upper bits
the major version.
+ .. member:: TSRemapPluginInfo plugin_info
+
+ An opaque object, which holds various details about the currently loaded and running
+ plugin. You can't access the details directly, but rather must call an acess function
Review Comment:
access
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] zwoop commented on pull request #8879: Adds a new member for TSRemapInterface tracking the plugin loaded
Posted by GitBox <gi...@apache.org>.
zwoop commented on PR #8879:
URL: https://github.com/apache/trafficserver/pull/8879#issuecomment-1157071160
I fixed the typo Randall pointed out, so need another +1 :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org