You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/08/31 01:55:02 UTC
[GitHub] [apisix] okaybase opened a new pull request #4940: chore(core): delay encode log data and format log
okaybase opened a new pull request #4940:
URL: https://github.com/apache/apisix/pull/4940
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
delay encode log data and format log
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a change in pull request #4940: chore(core): format log output
Posted by GitBox <gi...@apache.org>.
okaybase commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698935104
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format log output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4940: chore(core): delay encode log data and format log
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698929414
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
We don't delay encode for error level log, which is high enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a change in pull request #4940: chore(core): format log output
Posted by GitBox <gi...@apache.org>.
okaybase commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698935104
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format log output.
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format log output. @spacewander
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format the log output. @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #4940: chore(core): delay encode log data and format log
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #4940:
URL: https://github.com/apache/apisix/pull/4940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed pull request #4940: chore(core): delay encode log data and format log
Posted by GitBox <gi...@apache.org>.
spacewander closed pull request #4940:
URL: https://github.com/apache/apisix/pull/4940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a change in pull request #4940: chore(core): format log output
Posted by GitBox <gi...@apache.org>.
okaybase commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698935104
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format log output. @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] okaybase commented on a change in pull request #4940: chore(core): format log output
Posted by GitBox <gi...@apache.org>.
okaybase commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698935104
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
okay, just format the log output. @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4940: chore(core): delay encode log data and format log
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #4940:
URL: https://github.com/apache/apisix/pull/4940#discussion_r698929414
##########
File path: apisix/core/config_etcd.lua
##########
@@ -181,15 +181,15 @@ local function load_full_data(self, dir_res, headers)
data_valid, err = check_schema(self.item_schema, item.value)
if not data_valid then
log.error("failed to check item data of [", self.key,
- "] err:", err, " ,val: ", json.encode(item.value))
+ "] err:", err, ", val: ", json.delay_encode(item.value))
Review comment:
We don't delay encode for error level log, which is high enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org