You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/12 05:59:04 UTC

[GitHub] [dubbo] zonghaishang commented on issue #8370: [3.0] Meaningless/Confusing "key" in dynamic config's yaml

zonghaishang commented on issue #8370:
URL: https://github.com/apache/dubbo/issues/8370#issuecomment-897370229


   > 可以发现yaml中的key没有实际存在的意义，因为key中的服务信息，在DynamicConfiguration实现，以及ConfigChangeListener中都有，在AbstractConfiguratorListener#genConfiguratorsFromRawRule传入即可。此处key属性可取消。
   
   key是必要的，需要构建完整的override规则。因为配置规则value是个完整yaml,  scope=application，应用名字取自key。 scope=service，接口取自key。 因此多个配置，需要增加解析override url做一下key的过滤，目前没有过滤逻辑的。
   
   > 作为scope: service的配置，写入节点级配置路径也能生效，此处最好能控制监听逻辑。节点级只响应scope:application的yaml，服务级只响应scope:service的yaml，或者也可取消scope属性。
   
   类似前面的回复，同样缺少一层规则是否match过滤。
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org