You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/24 14:27:05 UTC

[GitHub] [shardingsphere] Zhoutzzz opened a new pull request #13780: Update _index.en.md

Zhoutzzz opened a new pull request #13780:
URL: https://github.com/apache/shardingsphere/pull/13780


   About shadow 'HINT' description
   
   Fixes #ISSUSE_ID.
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Zhoutzzz commented on a change in pull request #13780: Update _index.en.md

Posted by GitBox <gi...@apache.org>.
Zhoutzzz commented on a change in pull request #13780:
URL: https://github.com/apache/shardingsphere/pull/13780#discussion_r756743250



##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are

Review comment:
       I agree with what you said, but the purpose of adding this document is to make others better understand the matching mode of rules, because the configuration of this part is less described in the current document. At the same time, I think my change does not induce others to use it, but to tell others how rules are matched




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] soulasuna commented on a change in pull request #13780: Update _index.en.md

Posted by GitBox <gi...@apache.org>.
soulasuna commented on a change in pull request #13780:
URL: https://github.com/apache/shardingsphere/pull/13780#discussion_r756519495



##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are

Review comment:
       Thank you very much for your suggestions.
   But I think the document should be a "neutral" point of view to explain the function. 
   Rather than "inducing" users how to use it.

##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: true
+        user_id: 2
+```
+For example, the 'props' item have `2` configure, the following syntax can be used in SQL:
+```sql
+/*shadow:true,user_id:2*/、/*shadow:true,user_id:2,foo:bar,.....*/
+```

Review comment:
       Preferably a SQL statement that completes the structure.

##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: true
+        user_id: 2

Review comment:
       Indentation format error in yaml configuration.

##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: true
+        user_id: 2
+```
+For example, the 'props' item have `2` configure, the following syntax can be used in SQL:
+```sql
+/*shadow:true,user_id:2*/、/*shadow:true,user_id:2,foo:bar,.....*/
+```
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: false
+```
+For example, the 'props' item have `1` configure, the following syntax can be used in SQL:
+```sql
+/*shadow:false*/、/*shadow:false,user_id:2,foo:bar,.....*/
+```

Review comment:
       Preferably a SQL statement that completes the structure.

##########
File path: docs/document/content/reference/shadow/_index.en.md
##########
@@ -248,4 +248,29 @@ props:
   sql-comment-parse-enabled: true
 ```
 
-**Note**: The default shadow algorithm only supports note shadow algorithm.
+**Note**:
+The default shadow algorithm only supports note shadow algorithm.
+When using HINT, ensure that the configuration items of `props` in the configuration file are less than or equal to those in the SQL comment, and that the configuration items in the configuration file are the same as those in the SQL comment. The fewer the configuration items in the configuration file, the looser the matching conditions are
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: true
+        user_id: 2
+```
+For example, the 'props' item have `2` configure, the following syntax can be used in SQL:
+```sql
+/*shadow:true,user_id:2*/、/*shadow:true,user_id:2,foo:bar,.....*/
+```
+
+```yaml
+simple-note-algorithm:
+      type: SIMPLE_HINT
+      props:
+        shadow: false
+```

Review comment:
       Indentation format error in yaml configuration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #13780: Update _index.en.md

Posted by GitBox <gi...@apache.org>.
strongduanmu merged pull request #13780:
URL: https://github.com/apache/shardingsphere/pull/13780


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #13780: Update _index.en.md

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13780:
URL: https://github.com/apache/shardingsphere/pull/13780#issuecomment-978174948


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#13780](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8a5981c) into [master](https://codecov.io/gh/apache/shardingsphere/commit/d068e7215cbff4ed044031912ea338d31e9e5456?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d068e72) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13780/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #13780   +/-   ##
   =========================================
     Coverage     63.36%   63.36%           
     Complexity     1705     1705           
   =========================================
     Files          2763     2763           
     Lines         41203    41203           
     Branches       7029     7029           
   =========================================
     Hits          26110    26110           
     Misses        13103    13103           
     Partials       1990     1990           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [d068e72...8a5981c](https://codecov.io/gh/apache/shardingsphere/pull/13780?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org