You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by di...@apache.org on 2006/03/20 01:36:49 UTC
svn commit: r387088 -
/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java
Author: dion
Date: Sun Mar 19 16:36:48 2006
New Revision: 387088
URL: http://svn.apache.org/viewcvs?rev=387088&view=rev
Log:
pmd recommendations
Modified:
jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java
Modified: jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java
URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java?rev=387088&r1=387087&r2=387088&view=diff
==============================================================================
--- jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java (original)
+++ jakarta/commons/proper/jexl/trunk/src/java/org/apache/commons/jexl/util/introspection/UberspectImpl.java Sun Mar 19 16:36:48 2006
@@ -136,7 +136,7 @@
Method m = introspector.getMethod(obj.getClass(), methodName, args);
- return (m != null) ? new VelMethodImpl(m) : null;
+ return (m == null) ? null : new VelMethodImpl(m);
}
/**
@@ -160,7 +160,7 @@
* look for boolean isFoo()
*/
- if( executor.isAlive() == false)
+ if( !executor.isAlive())
{
executor = new BooleanPropertyExecutor(rlog, introspector, claz, identifier);
}
@@ -169,12 +169,12 @@
* if that didn't work, look for get("foo")
*/
- if (executor.isAlive() == false)
+ if (!executor.isAlive())
{
executor = new GetExecutor(rlog, introspector, claz, identifier);
}
- return (executor != null) ? new VelGetterImpl(executor) : null;
+ return (executor == null) ? null : new VelGetterImpl(executor);
}
/**
@@ -242,7 +242,7 @@
}
}
- return (vm!=null) ? new VelSetterImpl(vm) : null;
+ return (vm ==null) ? null : new VelSetterImpl(vm);
}
/**
@@ -359,13 +359,13 @@
{
ArrayList al = new ArrayList();
- if (putKey != null)
+ if (putKey == null)
{
- al.add(putKey);
al.add(value);
}
else
{
+ al.add(putKey);
al.add(value);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org