You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/03/07 09:35:13 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #9254: fix:
update release testing FLASK_APP
villebro opened a new pull request #9254: fix: update release testing FLASK_APP
URL: https://github.com/apache/incubator-superset/pull/9254
### CATEGORY
Choose one
- [x] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [x] Build / Development Environment
- [ ] Documentation
### SUMMARY
Since the `0.35` release, `FLASK_APP` needs to call the `create_app()` method. See #8621
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #9254: fix:
update release testing FLASK_APP
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #9254: fix: update release testing FLASK_APP
URL: https://github.com/apache/incubator-superset/pull/9254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on issue #9254: fix: update
release testing FLASK_APP
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #9254: fix: update release testing FLASK_APP
URL: https://github.com/apache/incubator-superset/pull/9254#issuecomment-596078812
Factory app pattern is a new thing on 0.36. There may be a few more like this.
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #9254: fix: update
release testing FLASK_APP
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #9254: fix: update release testing FLASK_APP
URL: https://github.com/apache/incubator-superset/pull/9254#issuecomment-596075171
Going to merge this to unblock the release process, I don't feel comfortable doing a release without doing this step by the book.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org