You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/13 13:50:40 UTC
[GitHub] [superset] DBouwmans opened a new issue #17088: Hide creation button when not having creation rights
DBouwmans opened a new issue #17088:
URL: https://github.com/apache/superset/issues/17088
**Problem description**
As a user of superset, with rights to only view existing dashboards, I would expect not to see the + dashboard buttons. Currently, the + dashboard button provides an error that the user doesn’t have the rights to create a dashboard, but I want to hide the button instead of providing this error.
This is exactly the same for creating dashboards and queries. I don’t want the ReadOnly end users to see the creation buttons. The fact that they can click on it makes it confusing to them.
**Current situation**
- Still able to click on add dashboard/chart/SQL query when they don’t have the rights to do so. When they do, the following error ‘Access is Denied’ appears
- Same applies to the + buttons on the main page.
- The user is still able to view the ‘Mine’ tabs (which is unnecessary, since they can’t have dashboards of their own since they don’t have the rights)
**Desired solution**
- There are no + buttons for creation actions a user doesn’t have the rights for (in the menu bar or on the home page)
- The ‘Mine’ tabs are no longer visible when the user doesn’t have the rights for creating that object.
- For queries, the whole part of saved queries could be deleted since you can only view your own. However, I know that a functionality to favorite queries is requested/being developed so I would understand the choice to not do this.
**Describe alternatives you've considered**
This couldn’t be successfully resolved in css because it only relates to specific roles, others should still be able to view the + Dashboard button when they do have a role with these rights.
**Additional context**
Please let me know if this feature request requires any additional information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu commented on issue #17088: Hide creation button when not having creation rights
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu commented on issue #17088:
URL: https://github.com/apache/superset/issues/17088#issuecomment-950006475
I believe this PR: https://github.com/apache/superset/pull/17157 help solved the top navigation + button part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rosemarie-chiu edited a comment on issue #17088: Hide creation button when not having creation rights
Posted by GitBox <gi...@apache.org>.
rosemarie-chiu edited a comment on issue #17088:
URL: https://github.com/apache/superset/issues/17088#issuecomment-950006475
I believe this PR: https://github.com/apache/superset/pull/17157 help solved the top navigation + button part. cc @hughhhh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org