You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:07:53 UTC
[GitHub] [solr-operator] thelabdude commented on a change in pull request #318: Option to watch for updates to the mTLS cert used by the operator to call Solr pods
thelabdude commented on a change in pull request #318:
URL: https://github.com/apache/solr-operator/pull/318#discussion_r699702285
##########
File path: helm/solr-operator/templates/deployment.yaml
##########
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
- --tls-skip-verify-server={{ .Values.mTLS.insecureSkipVerify }}
{{- end }}
+ {{- if .Values.mTLS.watchForUpdates }}
+ - --tls-watch-cert={{ .Values.mTLS.watchForUpdates }}
Review comment:
ha ha! good catch, was just copy-and-pasting senselessly ...
##########
File path: helm/solr-operator/templates/deployment.yaml
##########
@@ -64,6 +64,10 @@ spec:
{{- if .Values.mTLS.insecureSkipVerify }}
- --tls-skip-verify-server={{ .Values.mTLS.insecureSkipVerify }}
{{- end }}
+ {{- if .Values.mTLS.watchForUpdates }}
+ - --tls-watch-cert={{ .Values.mTLS.watchForUpdates }}
Review comment:
verified by doing:
```
helm template helm/solr-operator --set mTLS.watchForUpdates=false
```
resulting config is:
```
args:
- -zk-operator=true
- --tls-skip-verify-server=true
- --tls-watch-cert=false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org