You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/25 22:41:25 UTC

[GitHub] [flink] NicoK opened a new pull request #8884: [FLINK-12981][metrics] ignore NaNs in percentile implementation

NicoK opened a new pull request #8884: [FLINK-12981][metrics] ignore NaNs in percentile implementation
URL: https://github.com/apache/flink/pull/8884
 
 
   ## What is the purpose of the change
   
   Histogram metrics report `long` values and therefore, there is no `Double.NaN` in `DescriptiveStatistics`' data and there is no need to cleanse it while working with it.
   
   Please note that this PR is based on #8877.
   
   ## Brief change log
   
   - set a percentile implementation with ' NaNStrategy.FIXED' 
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as derivatives of `AbstractHistogramTest`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive): **no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **JavaDocs**
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services