You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/22 16:01:29 UTC
[GitHub] [pulsar] cbornet opened a new pull request, #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
cbornet opened a new pull request, #16747:
URL: https://github.com/apache/pulsar/pull/16747
### Motivation
The assertion in `KubernetesRuntimeTest::verifyJavaInstance` was removed by accident in #11417
### Modifications
Put back the `assertEquals`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is already covered by existing tests, such as `KubernetesRuntimeTest`
### Does this pull request potentially affect one of the following parts:
no
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
test
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1195511246
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1193099475
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1198364537
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1194103610
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1194706214
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1194330411
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- closed pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
Technoboy- closed pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
URL: https://github.com/apache/pulsar/pull/16747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cbornet commented on pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #16747:
URL: https://github.com/apache/pulsar/pull/16747#issuecomment-1197401780
/pulsarbot rerun-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #16747: [improve][functions] Missing assertion in KubernetesRuntimeTest::verifyJavaInstance
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #16747:
URL: https://github.com/apache/pulsar/pull/16747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org