You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/02/03 11:37:51 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
ztzg opened a new pull request #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243
This patch allows one to access the C client Cyrus SASL support (ZOOKEEPER-1112) from the Perl binding by passing a `--with-sasl2` flag (and, optionally, header and lib locations):
perl Makefile.PL \
--with-sasl2 \
--sasl2-include=/path/to/sasl2/include \
--sasl2-lib=/path/to/sasl2/lib
When enabled, `Net::ZooKeeper->new(...)` admits a new key, `sasl_options`, which can be used to automatically authenticate with the server during connections (including reconnects).
Some of the preparatory work for this contribution, which is available in the other commits, may also fix [ZOOKEEPER-3303](https://issues.apache.org/jira/browse/ZOOKEEPER-3303), which is about compilation issues. The resulting patch builds with GCC 8.3.0 in a (moderately) "hardened" environment; it also passes all enabled tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
nkalmar commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-611085356
pushed to master only, as ZOOKEEPER-1112 is only on that branch.
Thanks @ztzg
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-602676848
@Randgalt: I know about it, and generally agree—but the goal of this specific PR is to enable existing Perl programs to SASL-authenticate with current servers while keeping changes to a minimum.
(FWIW, I had a look at your branches, and am "monitoring" ZOOKEEPER-102. Everything looks very promising there, but "ingestion" into a stable ZK release is likely to take a while.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-609925777
@nkalmar: Pinging you again :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-581379653
@eolivelli: Should I add you as a reviewer on this? I understand it is not your "domain," but you had some interesting comments about the Perl module on [ZOOKEEPER-3303](https://issues.apache.org/jira/browse/ZOOKEEPER-3303?focusedCommentId=16790978&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16790978):
> Honestly I wasn't aware of the perl module, it is not compiled using neither ant nor the new maven build.
> We should definitely and automatic build and tests for the perl module.
(I am willing to help with the integration, but would like to have your comments.)
Also: would you have other reviewers to recommend?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-602475786
Dear @eolivelli, @HariSekhon, @chrisd8088, @nrh, @nkalmar, @symat, @enixon:
I understand that Perl might not be the hottest topic in ZooKeeper land, but is there something one of us could do to get this moving?
Cheers, -D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-603781438
@phunt can you take a look please ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-602691738
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] nkalmar commented on issue #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
nkalmar commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-602653743
The sad truth is that most contrib projects gets neglected :(
Honestly, I never run the perl client. If anyone at least familiar with Perl takes a look, I'm willing to commit. Ping me again if no one reviews it in the next few days. I'll at least try to run the client and commit if it seems to work. But I would feel comfortable if someone who at least written at least one line of Perl took a look :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604549540
Now thinking that @symat may be also interested in looking into this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] asfgit closed pull request #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-611097088
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg edited a comment on issue #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg edited a comment on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-611097088
Thanks!
(I would love to have `ZOOKEEPER-1112` and this in 3.6.x, btw. Should I prepare a PR?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] Randgalt commented on issue #1243: ZOOKEEPER-3714:
zkperl: Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
Randgalt commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-602654755
FYI: I have a gRPC prototype that I've been working on. I feel that the solution to non-JVM languages is gRPC. gRPC does have a Perl binding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] symat commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
symat commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604556116
I can take a look tomorrow... however, I haven't used much perl either. And also I am not a committer, so my +1 will not mean much :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl:
Add (Cyrus) SASL authentication support to Perl client
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1243: ZOOKEEPER-3714: zkperl: Add (Cyrus) SASL authentication support to Perl client
URL: https://github.com/apache/zookeeper/pull/1243#issuecomment-604560318
@symat: Not asking you to do extra work! I just thought I'd make you aware of this PR, as I keep seeing you foraging (almost) all dark corners of the ZK code base :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services