[GitHub] [ambari] timyuer commented on a diff in pull request #3646: AMBARI-25863: Fix a problem where the 'supported-refresh-commands' Element in configuration files for service was invalided

["timyuer (via GitHub)" <gi...@apache.org>]

timyuer commented on code in PR #3646:
URL: https://github.com/apache/ambari/pull/3646#discussion_r1213986845


##########
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java:
##########
@@ -1743,15 +1743,22 @@ public boolean checkStaleConfigsStatusForHostComponent(ServiceComponentHost sch,
       String type = changedConfigType.getKey();
       stale |= (serviceInfo.hasConfigDependency(type) || componentInfo.hasConfigType(type));
       if (stale) {
-        changedProperties.addAll(changedConfigType.getValue());
+        for (String propertyName : changedConfigType.getValue()) {
+          changedProperties.add(type + "/" + propertyName);
+        }
       }
     }
 
     String refreshCommand = calculateRefreshCommand(stackInfo.getRefreshCommandConfiguration(), sch, changedProperties);
 
+    Map<String, HostConfig> actual = sch.getActualConfigs();
+
+    Map<String, Map<String, String>> desired = getEffectiveDesiredTags(cluster, sch.getHostName(),cluster.getDesiredConfigs());
+

Review Comment:
   > nit: any logs could help improve debugging?
   
   @virajjasani 
   Logging alone may not be enough, but I recommend using remote debug mode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ambari.apache.org
For additional commands, e-mail: dev-help@ambari.apache.org