You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "EvanMi (via GitHub)" <gi...@apache.org> on 2023/07/27 11:01:50 UTC
[GitHub] [camel] EvanMi opened a new pull request, #10855: fix doc problem, change 'turn of' to 'turn off'
EvanMi opened a new pull request, #10855:
URL: https://github.com/apache/camel/pull/10855
# Description
fix doc problem, change 'turn of' to 'turn off'
# Target
- [ ] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [ ] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [ ] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [ ] I have run `mvn clean install -DskipTests` locally and I have committed all auto-generated changes
<!--
You can run the aforementioned command in your module so that the build auto-formats your code. This will also be verified as part of the checks and your PR may be rejected if if there are uncommited changes after running `mvn clean install -DskipTests`.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653448567
You need to change the java source code, do a git grep to find where in the source code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653501765
> You need to change the java source code, do a git grep to find where in the source code
My git grep results show the keyword only appear in .json and .xsd, and they are all generated. And i find the field in org.apache.camel.processor.SendDynamicProcessor , but found no docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653390757
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653549218
in the javadoc in ToDynamicDefinition.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi closed pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi closed pull request #10855: fix doc problem, change 'turn of' to 'turn off'
URL: https://github.com/apache/camel/pull/10855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653607504
This PR is broken, do you mind start all over and from latest code from main branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10855: fix doc problem, change 'turn of' to 'turn off'
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10855:
URL: https://github.com/apache/camel/pull/10855#issuecomment-1653615779
> This PR is broken, do you mind start all over and from latest code from main branch
sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org