You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/05/19 05:44:00 UTC

[jira] [Work logged] (BEAM-14489) Make all TextIO SDF.

     [ https://issues.apache.org/jira/browse/BEAM-14489?focusedWorklogId=772277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-772277 ]

ASF GitHub Bot logged work on BEAM-14489:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/May/22 05:43
            Start Date: 19/May/22 05:43
    Worklog Time Spent: 10m 
      Work Description: lostluck opened a new pull request, #17712:
URL: https://github.com/apache/beam/pull/17712

   Removes the non-SDF version of TextIO, so that it's old pattern can't be copied. All meaningful runners understand SDFs, and we're confident in their execution at this stage.
   
   Per Go policy, the old *Sdf methods are marked deprecated, but will not be removed until a major version change, because this is a user use package.
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 772277)
    Remaining Estimate: 0h
            Time Spent: 10m

> Make all TextIO SDF.
> --------------------
>
>                 Key: BEAM-14489
>                 URL: https://issues.apache.org/jira/browse/BEAM-14489
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>            Priority: P2
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> We currently have two kinds of textio.Read an SDF version and a Non SDF version. They should be unified (removing the non-SDF one) to avoid confusing users.
> Since there are likely a number of various packages using one or the other, we will point others to the existing Read calls but mark the SDF ones as deprecated. They will not be removed, as that's the Go way.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)