[GitHub] [ignite] alex-plekhanov commented on a change in pull request #6911: IGNITE-12232 NPE while node join processing

[GitBox <gi...@apache.org>]

alex-plekhanov commented on a change in pull request #6911: IGNITE-12232 NPE while node join processing
URL: https://github.com/apache/ignite/pull/6911#discussion_r335415673
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/spi/discovery/tcp/ServerImpl.java
 ##########
 @@ -2044,7 +2044,11 @@ private boolean recordable(TcpDiscoveryAbstractMessage msg) {
      * @param rmtPerms The second set of permissions.
      * @return {@code True} if given parameters contain the same permissions, {@code False} otherwise.
      */
-    private boolean permissionsEqual(SecurityPermissionSet locPerms, SecurityPermissionSet rmtPerms) {
+    private boolean permissionsEqual(@Nullable SecurityPermissionSet locPerms,
+        @Nullable SecurityPermissionSet rmtPerms) {
+        if (locPerms == null || rmtPerms == null)
 
 Review comment:
   What if both `locPerms` and `rmtPerms` are `null`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services