You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@whirr.apache.org by "David Alves (Created) (JIRA)" <ji...@apache.org> on 2011/10/14 21:14:11 UTC
[jira] [Created] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
------------------------------------------------------------------------------------------------------------------
Key: WHIRR-399
URL: https://issues.apache.org/jira/browse/WHIRR-399
Project: Whirr
Issue Type: Improvement
Components: core
Reporter: David Alves
Priority: Minor
The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145331#comment-13145331 ]
Andrei Savu commented on WHIRR-399:
-----------------------------------
Committed. Seems to be working fine on cloudservers-us & aws-ec2 (zookeeper integration tests). Thanks David!
> Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-399
> URL: https://issues.apache.org/jira/browse/WHIRR-399
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: David Alves
> Assignee: David Alves
> Priority: Minor
> Attachments: WHIRR-399.patch
>
>
> The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
> The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Posted by "Andrei Savu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145317#comment-13145317 ]
Andrei Savu commented on WHIRR-399:
-----------------------------------
+1 nice cleanup. This is going to be really useful for WHIRR-421. Now running integration tests.
> Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-399
> URL: https://issues.apache.org/jira/browse/WHIRR-399
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: David Alves
> Assignee: David Alves
> Priority: Minor
> Attachments: WHIRR-399.patch
>
>
> The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
> The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Posted by "David Alves (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves reassigned WHIRR-399:
---------------------------------
Assignee: David Alves
> Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-399
> URL: https://issues.apache.org/jira/browse/WHIRR-399
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: David Alves
> Assignee: David Alves
> Priority: Minor
> Attachments: WHIRR-399.patch
>
>
> The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
> The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Posted by "David Alves (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13145139#comment-13145139 ]
David Alves commented on WHIRR-399:
-----------------------------------
Ok, after looking into it for a while I've given up on extracting common code from BootstrapClusterAction.
This patch should make it trivial to add new phases (start/stop) etc.
Please review!
> Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-399
> URL: https://issues.apache.org/jira/browse/WHIRR-399
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: David Alves
> Assignee: David Alves
> Priority: Minor
> Attachments: WHIRR-399.patch
>
>
> The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
> The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (WHIRR-399) Move common script setup and script
execution fork/join outside of ConfigureClusterAction and
DestroyClusterAction
Posted by "David Alves (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WHIRR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Alves updated WHIRR-399:
------------------------------
Attachment: WHIRR-399.patch
This patch depends on the patch on WHIRR-398.
All script execution logic is moved from Configure/Destroy cluster actions to ScriptBasedCluster actions.
This is already a major reduction in LOC for configure and destroy but I'm still looking into bootstrap (its different enough that it is not trivial to extract common code).
Unit tests pass.
> Move common script setup and script execution fork/join outside of ConfigureClusterAction and DestroyClusterAction
> ------------------------------------------------------------------------------------------------------------------
>
> Key: WHIRR-399
> URL: https://issues.apache.org/jira/browse/WHIRR-399
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: David Alves
> Priority: Minor
> Attachments: WHIRR-399.patch
>
>
> The script setup and fork/join execution code in ConfigureClusterAction and in DestroyClusterAction is nearly similar. BootstrapClusterAction may also share some similarities.
> The common code should be extracted elsewhere.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira