You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "seekskyworld (via GitHub)" <gi...@apache.org> on 2026/09/15 16:19:49 UTC
[I] bug(desktop): WorkHub controller owner registration breaks the main architecture gate [maka]
seekskyworld opened a new issue, #5357:
URL: https://github.com/apache/maka/issues/5357
### What happened
The renderer architecture gate fails on current `main` after #5214 registered `useWorkHubController` with owner symbol `WorkHubRoot`. The only existing controller call is inside its private child `WorkHubContents`, so even unrelated pull requests now fail before their affected suites run.
```
src/renderer/features/workhub/controller/use-workhub-controller.ts#useWorkHubController:
controller must be called inside WorkHubRoot
```
### How to reproduce
At `3dcf5a125447ad210649f2e3414512aa79813c0a`, install root dependencies and run:
```sh
node apps/desktop/scripts/check-renderer-architecture.mjs --base HEAD --strict-base
```
Expected: the registered production owner satisfies the existing gate. Actual: the command exits 1 with the error above. The same failure blocks #5354 in [CI run 34993142765](https://github.com/apache/maka/actions/runs/34993142765).
### Environment
- Source: `3dcf5a125447ad210649f2e3414512aa79813c0a`
- Reproduced locally on macOS / Node v26.4.0 and in Linux CI
- Surface: Desktop renderer architecture / CI
### Logs, screenshots, or additional context
`WorkHubRoot` currently installs the highlight provider, then `WorkHubContents` reads its `selectWork` callback and owns the controller. Lifting the highlight state into a local hook lets `WorkHubRoot` own both that state and the controller, while continuing to provide the same context around its existing contents. This can satisfy the registered owner without changing the architecture policy or exposing the controller.
Automated report by OpenAI Codex on behalf of the contributor. The unchanged source failure has been reproduced; an isolated repair is being validated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] bug(desktop): WorkHub controller owner registration breaks the main architecture gate [maka]
Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed issue #5357: bug(desktop): WorkHub controller owner registration breaks the main architecture gate
URL: https://github.com/apache/maka/issues/5357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org
Re: [I] bug(desktop): WorkHub controller owner registration breaks the main architecture gate [maka]
Posted by "seekskyworld (via GitHub)" <gi...@apache.org>.
seekskyworld commented on issue #5357:
URL: https://github.com/apache/maka/issues/5357#issuecomment-5683898712
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org