You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/27 20:14:29 UTC
[GitHub] [samza] kw2542 opened a new pull request #1423: SAMZA-2584: Refactor ClusterBasedJobCoordinator
kw2542 opened a new pull request #1423:
URL: https://github.com/apache/samza/pull/1423
Issues: In the deployment flow of a beam job, we will have a complicate flow: ClusterBasedJobCoordinator#main -> Beam main class -> JobCoordinatorLaunchUtil -> ClusterBasedJobCoordinator.
Changes:
1. Move ClusterBasedJobCoordinator#main to ClusterBasedJobCoordinatorRunner#main
2. Update run-jc.sh to invoke ClusterBasedJobCoordinatorRunner
Tests:
1. unit tests
2. Deployed hello samza job successfully with the change following instructions on http://samza.apache.org/startup/hello-samza/latest/
API Changes: None
Upgrade Instructions: None
Usage Instructions: None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] mynameborat edited a comment on pull request #1423: SAMZA-2584: Refactor ClusterBasedJobCoordinator
Posted by GitBox <gi...@apache.org>.
mynameborat edited a comment on pull request #1423:
URL: https://github.com/apache/samza/pull/1423#issuecomment-682173718
Can you merge with the latest master head? `ClusterBasedJobCoordinator` has locality refactor changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] mynameborat commented on pull request #1423: SAMZA-2584: Refactor ClusterBasedJobCoordinator
Posted by GitBox <gi...@apache.org>.
mynameborat commented on pull request #1423:
URL: https://github.com/apache/samza/pull/1423#issuecomment-682173718
Can you merge with the latest master head? `ClusterBasedJobCoordinator` has locality refactor changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [samza] kw2542 closed pull request #1423: SAMZA-2584: Refactor ClusterBasedJobCoordinator
Posted by GitBox <gi...@apache.org>.
kw2542 closed pull request #1423:
URL: https://github.com/apache/samza/pull/1423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org