[jira] [Resolved] (JCLOUDS-1497) Fix jclouds-labs after JCLOUDS-1496

["Ignasi Barrera (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/JCLOUDS-1497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ignasi Barrera resolved JCLOUDS-1497.
-------------------------------------
    Resolution: Fixed

> Fix jclouds-labs after JCLOUDS-1496
> -----------------------------------
>
>                 Key: JCLOUDS-1497
>                 URL: https://issues.apache.org/jira/browse/JCLOUDS-1497
>             Project: jclouds
>          Issue Type: Task
>          Components: jclouds-core
>            Reporter: Olaf Flebbe
>            Priority: Major
>             Fix For: 2.2.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> See https://builds.apache.org/job/jclouds-labs/46/
> In order to reproduce run in jclouds-labs
> {code}
>  mvn -DskipTests  install  -U -e -Psrc,doc,jenkins
> {code}
> checkstyle-suppressions.xml  is not found in jclouds-labs. checkstyle.xml is found because it is included in jclouds-resources.jar. Adding checkstyle-suppressions to jclouds-resources did not work either:
> checkstyle-6.1.1 does load supressions from the class path, but IMO incorrectly (see https://github.com/checkstyle/checkstyle/blob/checkstyle-6.1.1/src/main/java/com/puppycrawl/tools/checkstyle/filters/SuppressionsLoader.java )
> {code}
> // check to see if the file is in the classpath
>                     try {
>                         final URL configUrl = SuppressionsLoader.class
>                                 .getResource(aFilename);
>                         if (configUrl == null) {
>                             throw new FileNotFoundException(aFilename);
>                         }
>                         uri = configUrl.toURI();
>  {code}
> This won't load stuff from jclouds-resources.jar on the classpath, but resources from checkstyle itself.
> Even using current checkstyle will not work, since this code has only been refactored but func-wise not altered.
> So we have only a limited number of options (beyond fixing checkstyle).
> # Add the file/dir resources/checkstyle-suppressions.xml to jclouds (having an ugly dependency) 
> # Remove the check triggering the checkstyle problem.
> The check triggering the problem where we need the suppressions for, is the "header" module checking for the presence of the proper apache license header in each java file. 
> May I suggest to remove the "header" check, since it is already covered by the apache-rat tool anyway? (Problem arises because some autogenerated transient code  does not include the ASF license header.)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)