[GitHub] [iotdb] wangchao316 commented on a diff in pull request #10789: [IOTDB-6061] Fix the instability failure caused by initServer in IoTConsensus UT not binding to the corresponding port

["wangchao316 (via GitHub)" <gi...@apache.org>]

wangchao316 commented on code in PR #10789:
URL: https://github.com/apache/iotdb/pull/10789#discussion_r1289724865


##########
iotdb-core/consensus/src/test/java/org/apache/iotdb/consensus/iot/ReplicateTest.java:
##########
@@ -115,8 +115,7 @@ public void changeConfiguration(int i) {
         Files.delete(configurationPath);
       }
       Files.move(tmpConfigurationPath, configurationPath);
-    } catch (IOException e) {
-      logger.error("Unexpected error occurs when persisting configuration", e);
+    } catch (IOException ignored) {

Review Comment:
   haha , xinyu, this is a code smell



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org