You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/06/12 22:49:52 UTC
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7159
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Occasionally we'd see HBase fail to startup properly on CentOS 7
clusters. The symptom was that HBase would not open the required nodes
in zookeeper, signaling its readiness.
As a workaround, this change includes waiting for the Zookeeper nodes
into the retry logic.
Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
---
M testdata/bin/run-hbase.sh
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/7159/1
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "anujphadke (Code Review)" <ge...@cloudera.org>.
anujphadke has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "David Knupp (Code Review)" <ge...@cloudera.org>.
David Knupp has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
Patch Set 2: Verified+1
(1 comment)
A private build passed here, and I had checked "dry run", so I'm manually marking this as verified.
http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/725/
http://gerrit.cloudera.org:8080/#/c/7159/1/testdata/bin/run-hbase.sh
File testdata/bin/run-hbase.sh:
PS1, Line 127: brea
> break
Done
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7159/1/testdata/bin/run-hbase.sh
File testdata/bin/run-hbase.sh:
PS1, Line 127: brea
break
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has uploaded a new patch set (#2).
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Occasionally we'd see HBase fail to startup properly on CentOS 7
clusters. The symptom was that HBase would not open the required nodes
in zookeeper, signaling its readiness.
As a workaround, this change includes waiting for the Zookeeper nodes
into the retry logic.
Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
---
M testdata/bin/run-hbase.sh
1 file changed, 11 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/59/7159/2
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[Impala-ASF-CR] IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged.
Change subject: IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
......................................................................
IMPALA-5223: Add waiting for HBase Zookeeper nodes to retry loop
Occasionally we'd see HBase fail to startup properly on CentOS 7
clusters. The symptom was that HBase would not open the required nodes
in zookeeper, signaling its readiness.
As a workaround, this change includes waiting for the Zookeeper nodes
into the retry logic.
Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Reviewed-on: http://gerrit.cloudera.org:8080/7159
Reviewed-by: Michael Brown <mi...@cloudera.com>
Reviewed-by: anujphadke <ap...@cloudera.com>
Reviewed-by: David Knupp <dk...@cloudera.com>
Tested-by: Lars Volker <lv...@cloudera.com>
---
M testdata/bin/run-hbase.sh
1 file changed, 11 insertions(+), 4 deletions(-)
Approvals:
David Knupp: Looks good to me, approved
Michael Brown: Looks good to me, approved
Lars Volker: Verified
anujphadke: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/7159
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id8dbdff4ad02cac1322e7d580e0a6971daf6ea28
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: David Knupp <dk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: anujphadke <ap...@cloudera.com>