You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Roger Meier <ro...@bufferoverflow.ch> on 2014/06/28 18:21:20 UTC
Re: Thrift compiler and config.h
Quoting Jens Geyer <je...@hotmail.com>:
> Hi *,
>
> I just recognized that (if I don’t overlook anything) the config.h
> file created by autoconf in the Thrift root folder is included into
> the C++ library, but not in the compiler itself. There’s only a
> Windows config.h, but that’s a different one.
thrift-config.h is the relevant file
https://git-wip-us.apache.org/repos/asf/thrift/repo?p=thrift.git;a=blob;f=lib/cpp/src/thrift/thrift-config.h;hb=HEAD
it includes the config.h created during ./configure process or the
windows thrift/windows/config.h
>
> Is there a specific reason for that?
yes, autoconf vs. windows build.
on Unix-like platforms some features are used if available depending
on config.h input.
> Would it be a problem if I include that file?
please use thrift/thrift-config.h if possible
regards
-roger
>
> Thanks,
> JensG
Re: Thrift compiler and config.h
Posted by Roger Meier <ro...@bufferoverflow.ch>.
Quoting Jens Geyer <je...@hotmail.com>:
> Hi Roger,
>
>> thrift-config.h is the relevant file lib/cpp/src/thrift/thrift-config.h
>
> are you sure that this file is used in the Thrift compiler code?
No this is not used within the compiler
Sorry Jens! I missed the subject "Thrift compiler and config.h"...
cheers
-roger
>
> JensG
>
>
> -----Ursprüngliche Nachricht----- From: Roger Meier
> Sent: Saturday, June 28, 2014 6:21 PM
> To: dev@thrift.apache.org ; Jens Geyer
> Subject: Re: Thrift compiler and config.h
>
>
> Quoting Jens Geyer <je...@hotmail.com>:
>
>> Hi *,
>>
>> I just recognized that (if I don’t overlook anything) the config.h
>> file created by autoconf in the Thrift root folder is included into
>> the C++ library, but not in the compiler itself. There’s only a
>> Windows config.h, but that’s a different one.
>
> thrift-config.h is the relevant file
> https://git-wip-us.apache.org/repos/asf/thrift/repo?p=thrift.git;a=blob;f=lib/cpp/src/thrift/thrift-config.h;hb=HEAD
>
> it includes the config.h created during ./configure process or the
> windows thrift/windows/config.h
>
>>
>> Is there a specific reason for that?
> yes, autoconf vs. windows build.
> on Unix-like platforms some features are used if available depending
> on config.h input.
>
>> Would it be a problem if I include that file?
> please use thrift/thrift-config.h if possible
>
> regards
> -roger
>
>>
>> Thanks,
>> JensG
Re: Thrift compiler and config.h
Posted by Jens Geyer <je...@hotmail.com>.
Hi Roger,
> thrift-config.h is the relevant file lib/cpp/src/thrift/thrift-config.h
are you sure that this file is used in the Thrift compiler code?
JensG
-----Ursprüngliche Nachricht-----
From: Roger Meier
Sent: Saturday, June 28, 2014 6:21 PM
To: dev@thrift.apache.org ; Jens Geyer
Subject: Re: Thrift compiler and config.h
Quoting Jens Geyer <je...@hotmail.com>:
> Hi *,
>
> I just recognized that (if I don’t overlook anything) the config.h file
> created by autoconf in the Thrift root folder is included into the C++
> library, but not in the compiler itself. There’s only a Windows config.h,
> but that’s a different one.
thrift-config.h is the relevant file
https://git-wip-us.apache.org/repos/asf/thrift/repo?p=thrift.git;a=blob;f=lib/cpp/src/thrift/thrift-config.h;hb=HEAD
it includes the config.h created during ./configure process or the
windows thrift/windows/config.h
>
> Is there a specific reason for that?
yes, autoconf vs. windows build.
on Unix-like platforms some features are used if available depending
on config.h input.
> Would it be a problem if I include that file?
please use thrift/thrift-config.h if possible
regards
-roger
>
> Thanks,
> JensG