[GitHub] [incubator-devlake] klesh commented on a diff in pull request #5983: fix: azure devops db connection fail

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on code in PR #5983:
URL: https://github.com/apache/incubator-devlake/pull/5983#discussion_r1310242080


##########
backend/python/pydevlake/pydevlake/ipc.py:
##########
@@ -129,6 +129,8 @@ def create_db_engine(db_url) -> Engine:
     connect_args = dict(parse_qsl(urlparse(db_url).query))
     if 'parseTime' in connect_args:
         del connect_args['parseTime']
+    if 'loc' in connect_args:
+        del connect_args['loc']

Review Comment:
   just delete? shouldnt we convert ？



##########
backend/python/pydevlake/pydevlake/ipc.py:
##########
@@ -129,6 +129,8 @@ def create_db_engine(db_url) -> Engine:
     connect_args = dict(parse_qsl(urlparse(db_url).query))
     if 'parseTime' in connect_args:
         del connect_args['parseTime']
+    if 'loc' in connect_args:
+        del connect_args['loc']

Review Comment:
   just delete? shouldnt we convert ？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org