You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2008/01/17 18:11:34 UTC

[jira] Created: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Introduce a caching logical connection and logical prepared statement in the client driver
------------------------------------------------------------------------------------------

                 Key: DERBY-3326
                 URL: https://issues.apache.org/jira/browse/DERBY-3326
             Project: Derby
          Issue Type: Sub-task
          Components: JDBC, Network Client
    Affects Versions: 10.4.0.0
            Reporter: Kristian Waagan
            Assignee: Kristian Waagan
             Fix For: 10.4.0.0


A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-3b-new_classes.stat
                derby-3326-3b-new_classes.diff

'derby-3326-3b-new_classes.diff' is a new version with changes in LogicalStatementEntity and a test.
The test is a package private test, and can be built and run with 'ant pptesting junit-pptesting'.

It is hard to write a proper "normal" test, as statement pooling is supposed to be transparent to the user and there are no methods to obtain information about the cache itself etc.
The only ideas I have come up with so far, is making sure it is enabled (by checking implementation details, like which class is used), and making sure nothing fails if you overflow the cache etc.

To test the logical forwarding classes, I will identify some suitable existing tests and run them with a connection pool data source decorator.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-4a-cpdsc_shutEngine.diff

'derby-3326-4a-cpdsc_shutEngine.diff' implements Connector.shutEngine for ConnectionPoolDataSourceConnector.
store.BootAllTest passes when run with TestConfiguration.connectionCPDecorator.
BTW, is there a reason why shutEngine isn't implemented for the XA connector?

Patch ready for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info: [Patch Available]

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-6b-npe_fix_synch_CLC.diff

'derby-3326-6b-npe_fix_synch_CLC.diff' removes one line from each of the two affected files, that belonged to another JIRA/patch.

Committed patch 6b to trunk with revision 631258.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan resolved DERBY-3326.
------------------------------------

    Resolution: Fixed

Resolving the issue.
There is still a minor issue regarding the prepare calls taking an int and a string array. The assert will trigger in sane builds, whereas in insane builds enabling statement caching will give you the same behavior as without caching.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff, derby-3326-8a-use_session_data_caching.diff, derby-3326-9a-temp_table_test.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info:   (was: [Patch Available])

Committed 'derby-3326-7a-prepare_column_indexes_names_fix.diff' to trunk with revision 631569.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info: [Patch Available]

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info:   (was: [Patch Available])

Committed 'derby-3326-2a-method_rename.diff' to trunk with revision 629739.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-9a-temp_table_test.diff

'derby-3326-9a-temp_table_test.diff' adds a test in jdbcapi.StatementPoolingTest that tests that temporary tables are deleted and not visible across logical connections.
Also set the createDatabase to create on the data source for some of the tests, so they can be run individually and not fail if the database hasn't been created yet.

Committed to trunk with revision 644360 and to the 10.4 branch with revision 644373.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff, derby-3326-8a-use_session_data_caching.diff, derby-3326-9a-temp_table_test.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-2a-method_rename.diff

'derby-3326-2a-method_rename.diff' renames the method ClientPooledConnection.trashConnection to informListeners, as this reflects better what the method does.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-8a-use_session_data_caching.diff

'derby-3326-8a-use_session_data_caching.diff' enables the use of the cached session data (the current schema) brought by DERBY-3192. Thanks Dyre :)

Committed 8a to trunk with revision 632088.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff, derby-3326-8a-use_session_data_caching.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info:   (was: [Patch Available])

Committed 'derby-3326-4a-cpdsc_shutEngine.diff' to trunk with revision 631123.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan closed DERBY-3326.
----------------------------------


> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff, derby-3326-8a-use_session_data_caching.diff, derby-3326-9a-temp_table_test.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-6a-npe_fix_synch_CLC.diff

'derby-3326-6a-npe_fix_synch_CLC.diff'  fixes an obvious NPE I overlooked and adds synchronization for the close method.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-1a_cpds_testing_preparation.stat
                derby-3326-1a_cpds_testing_preparation.diff

'derby-3326-1a_cpds_testing_preparation.diff' is a preparation step for reusing existing tests with a ConnectionPoolDataSource producing connections with statement pooling enabled.
Summary of changes:

* TestConfiguration
  Added method 'connectionCPDecorator'.

* ConnectionPoolDataSourceConnector
  Added new class (basically a copy of XADataSourceConnector).

Patch ready for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12568959#action_12568959 ] 

Kristian Waagan commented on DERBY-3326:
----------------------------------------

When working on this patch, I found a possible problematic area with
regards to synchronization. The problem is that a physical statement can
be taken out of the statement cache before it has been reset for reuse.
Calls will still be synchronized in the physical statement, but I think
there is a possibilty for nasty side effects due to ordering.
I have just introduced the method 'resetForReuse' for now, it does not
yet exists. It will/would involve actions like closing result sets.

Current situation, in a new file/method LogicalStatementEntity.close:
    // Try to insert the statement into the cache.
    if (cache.cacheStatement(stmtKey, temporaryPsRef)) {
        temporaryPsRef.resetForReuse();
    } else {
        // Statement was already in the cache, so we can close it.
        temporaryPsRef.close();
    }

There is a possibility for another thread to grab the physical statement
(named 'temporaryPsRef' above) just after it has been inserted.
There are several solutions, I describe some of the below. They all have
pros and cons...

* Solution #1: Do it unconditionally before insertion.
Change code to something like this:
    temporaryPsRef.resetForReuse();
    // Try to insert the statement into the cache.
    if (!cache.cacheStatement(stmtKey, temporaryPsRef)) {
        // Statement was already in the cache, so we can close it.
        temporaryPsRef.close();
    }

  - We end up doing some unnecessary work if stmt is discarded
    (this probably means an extra round-trip, but should rarely happen)
  - Harder to use the cache correctly?
  + No changes to statement cache, simple.

* Solution #2: Let the cache to the work.
One could add another interace, say 'ReusableStatement', with two
methods: discard() and resetForReuse(). Both would throw SQLException.
One would simply call cache.cacheStatement(stmtKey, temporaryPsRef), which
could do something like this while holding synchronization on the cache:
    final boolean alreadyCached = this.statements.containsKey(statementKey);
    if (!alreadyCached) {
        ps.resetForReuse();
        statements.put(statementKey, ps);
    } else {
        ps.discard();
    }
    return !alreadyCached;

One could also imagine making the cache more generic, by introducing say
'ReusableJDBCObject' and rename the cache methods etc.

  + encapsulation
  + ease of use
  - yet another interface
  - cache methods throw exceptions

* Solution #3: Introduce a synchronization object to the cache
Partially as done other places in Derby, introducing a synchronization
object for doing composite actions. This would typically be the
connection instance. With regards to solution #1, the code would change
to the code below and the cache would have to synchronize on the same
object internally:
    synchronized (cache.getSynchronizationObject()) {
        // Try to insert the statement into the cache.
        if (cache.cacheStatement(stmtKey, temporaryPsRef)) {
            temporaryPsRef.resetForReuse();
        } else {
            // Statement was already in the cache, so we can close it.
            temporaryPsRef.close();
        }
    }

  + flexibility???
  - error prone
  - cache can be locked down by clients

One could also introduce some other variation of the above, but I was
in general hoping to avoid having to synchronize too much in the logical
entities, since the associated physical entity will synchronize as well
and the reference to the physical entity will be synchronized. The
common forwarding pattern I have intended to use is:
    getPhys[CP]s().<methodName>(<args>);
The get methods will throw an exception if the logical entity has been
closed, and the get methods and the close method will synchronize on the
same object (currently this is the LogicalStatementEntity).

Have I forgotten anything essential?
Other pieces of advice anyone want to share with me?


For my current patch I will go for solution #1 due to its simplicity,
but will consider changing it later based on feedback and further
investigation.

I expect to post patches for DERBY-3326, DERBY-3328 and DERBY-3329
tomorrow. What's left for sure then, is to integrate DERBY-3192, which
will happen under the DERBY-3326 issue.
These patches might need more work, but it should then be possible to
apply a set of patches and test the feature from trunk.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-5a-enable_logicalstmtentity_pptest.diff

Attached 'derby-3326-5a-enable_logicalstmtentity_pptest.diff' which enables the package private test LogicalStatementEntityTest to be run as part of the junit-pptesting ant target.
Committed the patch to trunk with revision 630512.

Note that the previously attached patch 4a is still uncommitted and up for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info:   (was: [Patch Available])

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570994#action_12570994 ] 

Kristian Waagan commented on DERBY-3326:
----------------------------------------

Committed 'derby-3326-3c-new_classes.diff' to trunk with revision 629734. The commit also included a patch for DERBY-3328.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-7a-prepare_column_indexes_names_fix.diff

'derby-3326-7a-prepare_column_indexes_names_fix.diff' fixes bug where statements prepared with prepareStatement(String,String[]|int[]) were always prepared with Statement.RETURN_GENERATED_KEYS.
The code now checks if the arrays are null or empty.

There is a related problem when the array has more than one element. The client driver currently doesn't throw an exception, and the assert kicks in (see CachingLogicalConnection). I haven't decided what to do with this. The easiest is probably to ignore this fact and collapse the if to handle only the null/empty case and the not-empty case.
Comments?

Patch ready for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff, derby-3326-5a-enable_logicalstmtentity_pptest.diff, derby-3326-6a-npe_fix_synch_CLC.diff, derby-3326-6b-npe_fix_synch_CLC.diff, derby-3326-7a-prepare_column_indexes_names_fix.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-3a-new_classes.stat
                derby-3326-3a-new_classes.diff

'derby-3326-3a-new_classes.diff' introduces the new classes to support statement pooling.
Note that some of the classes are almost pure forwarding classes, and the patch basically contains two classes with special logic (LogicalStatementEntity and StatementCacheInteractor), two connection classes with special logic and four forwarding classes (two for each of Prepared- and CallableStatement).
The "special logic classes" were introduced because I cannot inherit from two classes. I'm sure there are other design choices too.

I'm not quite happy with the code in LogicalStatementEntity, any suggestions for improvement?
Further, these things need more work:
 1) Integrate DERBY-3192 (compilation schema)
 2) The 'am.PreapredStatement.reset(true)' is just a "placeholder", and I have to check it and possibly write a special reset method for pooling.

If I get no major pushback on the design/approach, I will commit the patch rather quickly as part of incremental development. The code won't be enabled yet anyway.

Patch ready for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-1b_cpds_testing_preparation.diff

'derby-3326-1b_cpds_testing_preparation.diff' contains a few additional documentation changes, and deprecates version 1a.

Committed version 1b to trunk with revision 615861.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info: [Patch Available]

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Derby Info: [Patch Available]

The small patch 'derby-3326-4a-cpdsc_shutEngine.diff' is ready for review.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff, derby-3326-4a-cpdsc_shutEngine.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-3326) Introduce a caching logical connection and logical prepared statement in the client driver

Posted by "Kristian Waagan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-3326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Waagan updated DERBY-3326:
-----------------------------------

    Attachment: derby-3326-3c-new_classes.diff

'derby-3326-3c-new_classes.diff' contains some changes from the earlier versions, but the design is the same.
I will commit this later today and use it as a baseline for further work, unless someone want time to review it before it goes in.

I expect there will be some changes later, and please note that the patch in partial and does not enable any of the statement pooling code.

> Introduce a caching logical connection and logical prepared statement in the client driver
> ------------------------------------------------------------------------------------------
>
>                 Key: DERBY-3326
>                 URL: https://issues.apache.org/jira/browse/DERBY-3326
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC, Network Client
>    Affects Versions: 10.4.0.0
>            Reporter: Kristian Waagan
>            Assignee: Kristian Waagan
>             Fix For: 10.4.0.0
>
>         Attachments: derby-3326-1a_cpds_testing_preparation.diff, derby-3326-1a_cpds_testing_preparation.stat, derby-3326-1b_cpds_testing_preparation.diff, derby-3326-2a-method_rename.diff, derby-3326-3a-new_classes.diff, derby-3326-3a-new_classes.stat, derby-3326-3b-new_classes.diff, derby-3326-3b-new_classes.stat, derby-3326-3c-new_classes.diff
>
>
> A logical connection with statement caching capabilities is required to support JDBC prepared statement pooling. Further, a logical prepared statement object is also needed.
> The logical prepared statements will be generated by the logical connection's 'prepareStatement'-method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.